From 882953d971ba443117d7bb0520d5403c7a69ab2a Mon Sep 17 00:00:00 2001 From: Jeff Cross Date: Fri, 2 Aug 2013 09:21:33 -0700 Subject: [PATCH] fix(docs-bootstrap): Removed injector from bootstrapped docs samples This is necessary to make e2e tests pass for implementing #3411. At present, the docs are violating the rule being enforced by double-bootstrap prevention. --- .../angular-bootstrap/bootstrap-prettify.js | 1 + src/jqLite.js | 2 +- test/jqLiteSpec.js | 14 ++++++++++++++ test/testabilityPatch.js | 2 +- 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/docs/components/angular-bootstrap/bootstrap-prettify.js b/docs/components/angular-bootstrap/bootstrap-prettify.js index b42c7c3a7b2c..9d8a7d23482e 100644 --- a/docs/components/angular-bootstrap/bootstrap-prettify.js +++ b/docs/components/angular-bootstrap/bootstrap-prettify.js @@ -241,6 +241,7 @@ directive.ngEmbedApp = ['$templateCache', '$browser', '$rootScope', '$location', embedRootScope.$destroy(); }); + element.data('$injector', null); angular.bootstrap(element, modules); } }; diff --git a/src/jqLite.js b/src/jqLite.js index 6ac9998792a0..4a52cba018f8 100644 --- a/src/jqLite.js +++ b/src/jqLite.js @@ -330,7 +330,7 @@ function JQLiteInheritedData(element, name, value) { } while (element.length) { - if (value = element.data(name)) return value; + if ((value = element.data(name)) !== undefined) return value; element = element.parent(); } } diff --git a/test/jqLiteSpec.js b/test/jqLiteSpec.js index abfad064632a..913e61924726 100644 --- a/test/jqLiteSpec.js +++ b/test/jqLiteSpec.js @@ -126,6 +126,20 @@ describe('jqLite', function() { dealoc(doc); } ); + + it('should return null values', function () { + var ul = jqLite(''), + li = ul.find('li'), + b = li.find('b'); + + ul.data('foo', 'bar'); + li.data('foo', null); + expect(b.inheritedData('foo')).toBe(null); + expect(li.inheritedData('foo')).toBe(null); + expect(ul.inheritedData('foo')).toBe('bar'); + + dealoc(ul); + }); }); diff --git a/test/testabilityPatch.js b/test/testabilityPatch.js index 7b4fe0ec1abf..514a5fdbbdbd 100644 --- a/test/testabilityPatch.js +++ b/test/testabilityPatch.js @@ -56,7 +56,7 @@ afterEach(function() { forEachSorted(cache, function(expando, key){ angular.forEach(expando.data, function(value, key){ count ++; - if (value.$element) { + if (value && value.$element) { dump('LEAK', key, value.$id, sortedHtml(value.$element)); } else { dump('LEAK', key, angular.toJson(value));