From b165c5656c971a1a3a6b2a81d3b30f8f5fc4db19 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Tue, 13 Feb 2018 01:25:34 +0200 Subject: [PATCH] chore(docs.angularjs.org): install firebase dependencies before deploying Firebase is trying to execute our functions code locally in order to parse the triggers. Install npm dependencies to avoid errors like: ``` Error: Error parsing triggers: Cannot find module 'firebase-functions' ``` --- .../readme.firebase.docs.md | 2 +- scripts/travis/build.sh | 13 ++++++++++++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/scripts/docs.angularjs.org-firebase/readme.firebase.docs.md b/scripts/docs.angularjs.org-firebase/readme.firebase.docs.md index cd6019d77b64..10da862469df 100644 --- a/scripts/docs.angularjs.org-firebase/readme.firebase.docs.md +++ b/scripts/docs.angularjs.org-firebase/readme.firebase.docs.md @@ -20,4 +20,4 @@ build steps. Creates a server at localhost:5000 that serves from deploy/docs and uses the local function See /scripts/code.angularjs.org-firebase/readme.firebase.code.md for the firebase deployment to -code.angularjs.org \ No newline at end of file +code.angularjs.org diff --git a/scripts/travis/build.sh b/scripts/travis/build.sh index 980855388492..ed8838cc9574 100755 --- a/scripts/travis/build.sh +++ b/scripts/travis/build.sh @@ -2,6 +2,9 @@ set -e +readonly THIS_DIR=$(cd $(dirname $0); pwd) +readonly ROOT_DIR="$THIS_DIR/../.." + export BROWSER_STACK_ACCESS_KEY export SAUCE_ACCESS_KEY @@ -80,6 +83,14 @@ case "$JOB" in if [[ "$DEPLOY_DOCS" == true || "$DEPLOY_CODE" == true ]]; then grunt prepareDeploy + + if [[ "$DEPLOY_DOCS" == true ]]; then + # Install npm dependencies for Firebase functions. + ( + cd "$ROOT_DIR/scripts/docs.angularjs.org-firebase/functions" + npm install + ) + fi else echo "Skipping deployment build because conditions have not been met." fi @@ -94,4 +105,4 @@ case "$JOB" in or\ 'deploy'." ;; -esac \ No newline at end of file +esac