From 300cd6075577b25617c05d69e8ff14cd7bc0b651 Mon Sep 17 00:00:00 2001 From: Georgii Dolzhykov Date: Mon, 25 Dec 2017 02:07:25 +0200 Subject: [PATCH 1/2] docs(ngModel.NgModelController): correct description for `$viewChangeListeners` It was misleading. --- src/ng/directive/ngModel.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ng/directive/ngModel.js b/src/ng/directive/ngModel.js index 7802d05177e6..7aa21e01b2a5 100644 --- a/src/ng/directive/ngModel.js +++ b/src/ng/directive/ngModel.js @@ -127,8 +127,9 @@ var ngModelMinErr = minErr('ngModel'); * }; * ``` * - * @property {Array.} $viewChangeListeners Array of functions to execute whenever the - * view value has changed. It is called with no arguments, and its return value is ignored. + * @property {Array.} $viewChangeListeners Array of functions to execute whenever + * a change to the view value has caused a change to the model value. + * It is called with no arguments, and its return value is ignored. * This can be used in place of additional $watches against the model value. * * @property {Object} $error An object hash with all failing validator ids as keys. From 11c32f970954edfbcacb631ddc9edb6a2450d644 Mon Sep 17 00:00:00 2001 From: Georgii Dolzhykov Date: Fri, 29 Dec 2017 14:45:20 +0200 Subject: [PATCH 2/2] add links to $viewValue and $modelValue --- src/ng/directive/ngModel.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ng/directive/ngModel.js b/src/ng/directive/ngModel.js index 7aa21e01b2a5..b9aa13ce13ea 100644 --- a/src/ng/directive/ngModel.js +++ b/src/ng/directive/ngModel.js @@ -128,7 +128,8 @@ var ngModelMinErr = minErr('ngModel'); * ``` * * @property {Array.} $viewChangeListeners Array of functions to execute whenever - * a change to the view value has caused a change to the model value. + * a change to {@link ngModel.NgModelController#$viewValue `$viewValue`} has caused a change + * to {@link ngModel.NgModelController#$modelValue `$modelValue`}. * It is called with no arguments, and its return value is ignored. * This can be used in place of additional $watches against the model value. *