From faeeac594f3e8f66fb7939f76470c0203ad5c66d Mon Sep 17 00:00:00 2001
From: Eli Sadoff <snood1205@users.noreply.github.com>
Date: Mon, 3 Apr 2017 15:48:14 -0400
Subject: [PATCH 1/4] docs(uppercase): Added an example

I saw that the uppercase filter had no example so I decided to add a minimal example to explain how the uppercase filter works.
---
 src/ng/filter/filters.js | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/src/ng/filter/filters.js b/src/ng/filter/filters.js
index 3f83895f74c2..26a3dbb5a53e 100644
--- a/src/ng/filter/filters.js
+++ b/src/ng/filter/filters.js
@@ -709,6 +709,27 @@ var lowercaseFilter = valueFn(lowercase);
  * @kind function
  * @description
  * Converts string to uppercase.
- * @see angular.uppercase
+ * @example
+   <example name="filter-uppercase">
+     <file name="index.html">
+       <script>
+         angular.module('uppercaseFilterExample', [])
+           .controller('ExampleController', ['$scope', function($scope) {
+             $scope.title = 'This is a title';
+           }]);
+       </script>
+       <div ng-controller="ExampleController">
+         <!-- This title should be formatted normally -->
+         <h1>{{title}}</h1>
+         <!-- This title should be capitalized -->
+         <h1>{{title | uppercase}}</h1>
+       </div>
+     </file>
+     <file name="protractor.js" type="protractor">
+       it('should capitalize the text', function() {
+         expect(element(by.binding('title | uppercase')).getText()).toBe('THIS IS A TITLE');
+       });
+     </file>
+   </example>
  */
 var uppercaseFilter = valueFn(uppercase);

From 9f4a75e4a662a499391021e65ea57eff02d3574b Mon Sep 17 00:00:00 2001
From: Eli Sadoff <esadoff@ardiangroup.com>
Date: Wed, 5 Apr 2017 07:53:44 -0400
Subject: [PATCH 2/4] Made changes that were requested by @Narretz

---
 src/ng/filter/filters.js | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/ng/filter/filters.js b/src/ng/filter/filters.js
index 26a3dbb5a53e..148b8dd4b4f1 100644
--- a/src/ng/filter/filters.js
+++ b/src/ng/filter/filters.js
@@ -699,6 +699,7 @@ function jsonFilter() {
  * @description
  * Converts string to lowercase.
  * @see angular.lowercase
+ * @see angular.uppercase
  */
 var lowercaseFilter = valueFn(lowercase);
 
@@ -725,11 +726,6 @@ var lowercaseFilter = valueFn(lowercase);
          <h1>{{title | uppercase}}</h1>
        </div>
      </file>
-     <file name="protractor.js" type="protractor">
-       it('should capitalize the text', function() {
-         expect(element(by.binding('title | uppercase')).getText()).toBe('THIS IS A TITLE');
-       });
-     </file>
    </example>
  */
 var uppercaseFilter = valueFn(uppercase);

From afa34500d51743adfdf492716a68d07993cfe2cc Mon Sep 17 00:00:00 2001
From: Eli Sadoff <esadoff@ardiangroup.com>
Date: Fri, 7 Apr 2017 10:04:13 -0400
Subject: [PATCH 3/4] I believe that the changes made now fully comply with
 @narretz's recommendations

Thank you very much to @narretz for helping me through this process
---
 src/ng/filter/filters.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ng/filter/filters.js b/src/ng/filter/filters.js
index 148b8dd4b4f1..bc96bc56b462 100644
--- a/src/ng/filter/filters.js
+++ b/src/ng/filter/filters.js
@@ -698,8 +698,8 @@ function jsonFilter() {
  * @kind function
  * @description
  * Converts string to lowercase.
+ * {@link ng.filter.uppercase Reference the example in uppercase as they are nearly identical.}
  * @see angular.lowercase
- * @see angular.uppercase
  */
 var lowercaseFilter = valueFn(lowercase);
 
@@ -711,7 +711,7 @@ var lowercaseFilter = valueFn(lowercase);
  * @description
  * Converts string to uppercase.
  * @example
-   <example name="filter-uppercase">
+   <example module="uppercaseFilterExample" name="filter-uppercase">
      <file name="index.html">
        <script>
          angular.module('uppercaseFilterExample', [])

From 82034c23522b2d7fd9f31195b21da4744c633782 Mon Sep 17 00:00:00 2001
From: Martin Staffa <mjstaffa@googlemail.com>
Date: Fri, 7 Apr 2017 17:17:15 +0200
Subject: [PATCH 4/4] Fix link

---
 src/ng/filter/filters.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/ng/filter/filters.js b/src/ng/filter/filters.js
index bc96bc56b462..5a79a7799929 100644
--- a/src/ng/filter/filters.js
+++ b/src/ng/filter/filters.js
@@ -698,7 +698,9 @@ function jsonFilter() {
  * @kind function
  * @description
  * Converts string to lowercase.
- * {@link ng.filter.uppercase Reference the example in uppercase as they are nearly identical.}
+ *
+ * See the {@link ng.uppercase uppercase filter documentation} for a functionally identical example.
+ *
  * @see angular.lowercase
  */
 var lowercaseFilter = valueFn(lowercase);