From c005fc18322f79fd551f989fffd8c655e0401522 Mon Sep 17 00:00:00 2001 From: Julio Borja Barra Date: Sat, 15 Oct 2016 07:15:23 +0000 Subject: [PATCH 1/2] docs(ngModel.NgModelController): describe your change... If there's no else, then the same will happen in both inputs (the model value is overwritten). --- src/ng/directive/ngModel.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ng/directive/ngModel.js b/src/ng/directive/ngModel.js index a74e8a4bffae..73986e167a36 100644 --- a/src/ng/directive/ngModel.js +++ b/src/ng/directive/ngModel.js @@ -458,8 +458,9 @@ NgModelController.prototype = { * e.preventDefault(); * if (rollback) { * $scope.myForm[value].$rollbackViewValue(); + * } else { + * $scope.model[value] = ''; * } - * $scope.model[value] = ''; * } * }; * }]); From 31c455eb3cc52b581c6bdb5f6fc4d6d8dea209da Mon Sep 17 00:00:00 2001 From: Julio Borja Barra Date: Fri, 11 Nov 2016 09:25:00 +0000 Subject: [PATCH 2/2] Update ngModel.js Update commit to match @gkalpak 's observations. --- src/ng/directive/ngModel.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/ng/directive/ngModel.js b/src/ng/directive/ngModel.js index 73986e167a36..b0170e78030d 100644 --- a/src/ng/directive/ngModel.js +++ b/src/ng/directive/ngModel.js @@ -451,16 +451,15 @@ NgModelController.prototype = { * angular.module('cancel-update-example', []) * * .controller('CancelUpdateController', ['$scope', function($scope) { - * $scope.model = {}; + * $scope.model = {value1: '', value2: ''}; * * $scope.setEmpty = function(e, value, rollback) { * if (e.keyCode === 27) { * e.preventDefault(); * if (rollback) { * $scope.myForm[value].$rollbackViewValue(); - * } else { - * $scope.model[value] = ''; * } + * $scope.model[value] = ''; * } * }; * }]);