From 55e379d25b642d31326e6e02ddd960da91c4ec78 Mon Sep 17 00:00:00 2001 From: dmitriz Date: Tue, 12 Jan 2016 15:05:20 +0000 Subject: [PATCH] docs(CONTRIBUTING): add warning about forced push Add warning about the possible consequences of a forced push docs(CONTRIBUTING): add warning about forced push --- CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index dad1bdbbf93f..90fa19912bab 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -123,12 +123,17 @@ Before you submit your pull request consider the following guidelines: * If we suggest changes then: * Make the required updates. * Re-run the Angular test suite to ensure tests are still passing. + * Commit your changes to the branch. * Rebase your branch and force push to your GitHub repository (this will update your Pull Request): +If the PR gets too outdated we may ask you to rebase and force push to update the PR: + ```shell git rebase master -i git push origin my-fix-branch -f ``` + +WARNING. Squashing or reverting commits and forced push thereafter may delete all in-code comments by others in your commits. That's it! Thank you for your contribution!