From c59ffcb378cd53dba67876eb6ddddb5f78972ebe Mon Sep 17 00:00:00 2001 From: Pawel Kozlowski Date: Sun, 7 Dec 2014 20:50:08 +0100 Subject: [PATCH] refactor($http): avoid using closure vars in serverRequest fn --- src/ng/http.js | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/ng/http.js b/src/ng/http.js index 3a73a137c0e2..efc3c9f92487 100644 --- a/src/ng/http.js +++ b/src/ng/http.js @@ -738,23 +738,22 @@ function $HttpProvider() { */ function $http(requestConfig) { - var config = { - method: 'get', - transformRequest: defaults.transformRequest, - transformResponse: defaults.transformResponse - }; - var headers = mergeHeaders(requestConfig); if (!angular.isObject(requestConfig)) { throw minErr('$http')('badreq', 'Http request configuration must be an object. Received: {0}', requestConfig); } - extend(config, requestConfig); - config.headers = headers; + var config = extend({ + method: 'get', + transformRequest: defaults.transformRequest, + transformResponse: defaults.transformResponse + }, requestConfig); + + config.headers = mergeHeaders(requestConfig); config.method = uppercase(config.method); var serverRequest = function(config) { - headers = config.headers; + var headers = config.headers; var reqData = transformData(config.data, headersGetter(headers), config.transformRequest); // strip content-type if data is undefined