refactor($rootScope): add warnings when emitting/broadcasting on a destroyed scope #6784
Conversation
…stroyed scope When a scope is destroyed, all event listeners gets unregistered, and the connection to the parent/child scopes are removed. Because of this, no one is noticed of the event. $emit and $broadcast now logs a warning when trying to emit or broadcast an event on a destroyed scope. Closes angular#6768
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Yes, well, it's a bit of a slippery slope in that case. If it's the child of a destroyed scope, and the child scope hasn't yet been destroyed then it can still call listeners on the child scope. So my reasoning for only checking |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
Subscopes of destroyed scopes have |
|
@thorn0 did you mean: set to true? |
|
Oops, yes, I did. |
When a scope is destroyed, all event listeners gets unregistered, and the connection to
the parent/child scopes are removed. Because of this, no one is noticed of the event.
$emit and $broadcast now logs a warning when trying to emit or broadcast an event on
a destroyed scope.
Closes #6768