$http : ability to clear a request from the cache #5968 #6334
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Is this really needed? You can already do this with $cacheFactory |
|
yes, as there is no way to be sure you have the correct key for the cache On Wed, Feb 19, 2014 at 6:37 PM, Caitlin Potter notifications@github.comwrote:
|
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
CLA is signed as Dell Inc |
|
Is there something else I should be doing to update my CLA status? |
|
I also signed an individual CLA and switched my email address on this to match. Maybe that well help? |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
njs50
force-pushed
the
$httpUpdate
branch
2 times, most recently
from
e4682e3 to
5fc444c
Compare
…ests in $http cache Adds $http.removeCache method. Adds/implements replaceCache property in $http request configuration. Closes angular#5968
|
|
||
| var url = buildUrl(config.url, config.params); | ||
|
|
||
| var cache = isObject(config.cache) ? config.cache |
There was a problem hiding this comment.
Maybe this should be moved into a reusable function.
|
I would like to see more tests (e.g. that the correct cache is cleared, that params are taken into account when determining the cache key etc). |
|
I didn't even realise this PR was still around (opened feb 2014). I'm just going to close it and if someone still wants this functionality they can open it up again and update it. |
Previously it was not possible to remove data from $http cache (without duplicating internal functions in http to calculate the key used, which could change in the future...).
feat($http): change $http to allow removing/replacing individual requests in $http cache
Adds $http.removeCache method.
Adds/implements replaceCache property in $http request configuration.
Closes #5968