Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit ee327a1

Browse files
committed
few fixes to make tests pass with jquery
1 parent e646068 commit ee327a1

File tree

8 files changed

+29
-46
lines changed

8 files changed

+29
-46
lines changed

example/widgets.html

Lines changed: 0 additions & 34 deletions
This file was deleted.

scenario/widgets.html

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
33
<head>
44
<link rel="stylesheet" type="text/css" href="style.css"></link>
5-
<!--<script type="text/javascript" src="../lib/jquery/jquery-1.4.2.js"></script>-->
5+
<script type="text/javascript" src="../lib/jquery/jquery-1.4.2.js"></script>
66
<script type="text/javascript" src="../src/angular-bootstrap.js#autobind"></script>
77
</head>
88
<body ng-init="$window.$scope = this">
@@ -82,6 +82,16 @@
8282
</td>
8383
<td>button={{button}}</td>
8484
</tr>
85+
<tr><th colspan="3">Repeaters</th></tr>
86+
<tr>
87+
<td>ng-repeat</td>
88+
<td>
89+
<ul>
90+
<li ng-repeat="name in ['misko', 'adam']">{{name}}</li>
91+
</ul>
92+
</td>
93+
<td></td>
94+
</tr>
8595
</table>
8696
</body>
8797
</html>

src/jqLite.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ JQLite.prototype = {
9292
});
9393
},
9494

95+
//TODO: remove
9596
trigger: function(type) {
9697
var evnt = document.createEvent('MouseEvent');
9798
evnt.initMouseEvent(type, true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);

test/BinderTest.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -706,13 +706,13 @@ BinderTest.prototype.testItShouldSelectTheCorrectRadioBox = function() {
706706
var female = jqLite(c.node[0].childNodes[0]);
707707
var male = jqLite(c.node[0].childNodes[1]);
708708

709-
female.click();
709+
trigger(female, 'click');
710710
assertEquals("female", c.scope.sex);
711711
assertEquals(true, female[0].checked);
712712
assertEquals(false, male[0].checked);
713713
assertEquals("female", female.val());
714714

715-
male.click();
715+
trigger(male, 'click');
716716
assertEquals("male", c.scope.sex);
717717
assertEquals(false, female[0].checked);
718718
assertEquals(true, male[0].checked);

test/CompilerSpec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ describe('compiler', function(){
7272
var scope = compile('<span hello="misko" stop="true"><span hello="adam"/></span>');
7373
expect(log).toEqual("hello misko");
7474
});
75-
75+
7676
it('should allow creation of templates', function(){
7777
directives.duplicate = function(expr, element){
7878
element.replaceWith(document.createComment("marker"));
@@ -97,7 +97,7 @@ describe('compiler', function(){
9797
if (text == 'middle') {
9898
expect(textNode.text()).toEqual(text);
9999
parentNode.attr('hello', text);
100-
textNode.text('replaced');
100+
textNode[0].textContent = 'replaced';
101101
}
102102
});
103103
var scope = compile('before<span>middle</span>after');

test/directivesSpec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,19 +142,19 @@ describe("directives", function(){
142142
it('should ng-show', function(){
143143
var scope = compile('<div ng-hide="hide"></div>');
144144
scope.$eval();
145-
expect(element.css('display')).toEqual('');
145+
expect(isVisible(element)).toEqual(true);
146146
scope.$set('hide', true);
147147
scope.$eval();
148-
expect(element.css('display')).toEqual('none');
148+
expect(isVisible(element)).toEqual(false);
149149
});
150150

151151
it('should ng-hide', function(){
152152
var scope = compile('<div ng-show="show"></div>');
153153
scope.$eval();
154-
expect(element.css('display')).toEqual('none');
154+
expect(isVisible(element)).toEqual(false);
155155
scope.$set('show', true);
156156
scope.$eval();
157-
expect(element.css('display')).toEqual('');
157+
expect(isVisible(element)).toEqual(true);
158158
});
159159

160160
it('should ng-controller', function(){

test/testabilityPatch.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,12 @@ extend(angular, {
2727
});
2828

2929

30+
function trigger(element, type) {
31+
var evnt = document.createEvent('MouseEvent');
32+
evnt.initMouseEvent(type, true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
33+
(element[0] || element).dispatchEvent(evnt);
34+
}
35+
3036
function sortedHtml(element) {
3137
var html = "";
3238
(function toString(node) {

test/widgetsSpec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,10 @@ describe("input widget", function(){
115115
it('should type="checkbox"', function(){
116116
compile('<input type="checkbox" name="checkbox" checked ng-change="action = true"/>');
117117
expect(scope.checkbox).toEqual(true);
118-
element.click();
118+
trigger(element, 'click');
119119
expect(scope.checkbox).toEqual(false);
120120
expect(scope.action).toEqual(true);
121-
element.click();
121+
trigger(element, 'click');
122122
expect(scope.checkbox).toEqual(true);
123123
});
124124

@@ -142,7 +142,7 @@ describe("input widget", function(){
142142
expect(b.checked).toEqual(true);
143143
expect(scope.clicked).not.toBeDefined();
144144

145-
jqLite(a).click();
145+
trigger(a, 'click');
146146
expect(scope.chose).toEqual('A');
147147
expect(scope.clicked).toEqual(1);
148148
});

0 commit comments

Comments
 (0)