Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit e83465c

Browse files
mheveryvojtajina
authored andcommitted
Fix scenario runner on IE7, IE8
* add ng:disabled, ng:checked, ng:multiple, ng:readonly, ng:selected * fetch fixed cookbook/advancedform (use ng:disabled) * fire keydown instead of change on input * remove frame when test finishes
1 parent f370be8 commit e83465c

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

docs/content/cookbook/advancedform.ngdoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ ng:validate="regexp:zip"/><br/><br/>
7171
<input type="text" name="contact.value" ng:required/>
7272
[ <a href="" ng:click="form.contacts.$remove(contact)">X</a> ]
7373
</div>
74-
<button ng:click="cancel()" disabled="{{master.$equals(form)}}">Cancel</button>
75-
<button ng:click="save()" disabled="{{$invalidWidgets.visible() ||
74+
<button ng:click="cancel()" ng:disabled="{{master.$equals(form)}}">Cancel</button>
75+
<button ng:click="save()" ng:disabled="{{$invalidWidgets.visible() ||
7676
master.$equals(form)}}">Save</button>
7777

7878

src/markups.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,11 @@ angularTextMarkup('option', function(text, textNode, parentElement){
236236
*/
237237

238238
var NG_BIND_ATTR = 'ng:bind-attr';
239-
var SPECIAL_ATTRS = {'ng:src': 'src', 'ng:href': 'href'};
239+
var SPECIAL_ATTRS = {};
240+
forEach('src,href,checked,disabled,multiple,readonly,selected'.split(','), function(name) {
241+
SPECIAL_ATTRS['ng:' + name] = name;
242+
});
243+
240244
angularAttrMarkup('{{}}', function(value, name, element){
241245
// don't process existing attribute markup
242246
if (angularDirective(name) || angularDirective("@" + name)) return;

src/scenario/Application.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ angular.scenario.Application.prototype.navigateTo = function(url, loadFn, errorF
5858
this.executeAction(loadFn);
5959
} else {
6060
frame.css('display', 'none').attr('src', 'about:blank');
61+
frame.remove();
6162
this.context.find('#test-frames').append('<iframe>');
6263
frame = this.getFrame_();
6364
frame.load(function() {

src/scenario/dsl.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ angular.scenario.dsl('input', function() {
180180
return this.addFutureAction("input '" + this.name + "' enter '" + value + "'", function($window, $document, done) {
181181
var input = $document.elements(':input[name="$1"]', this.name);
182182
input.val(value);
183-
input.trigger('change');
183+
input.trigger('keydown');
184184
done();
185185
});
186186
};

0 commit comments

Comments
 (0)