WIP

Author: petebacondarwin

src/ngMessages/messages.js

@@ -683,14 +683,18 @@ function ngMessageDirectiveFactory() {
           assignRecords(staticExp);
         }
 
-        var currentElement, messageCtrl;
+        var currentElement, messageCtrl, neverAttached = true;
+        console.log('register', commentNode);
         ngMessagesCtrl.register(commentNode, messageCtrl = {
           test: function(name) {
             return contains(records, name);
           },
           attach: function() {
+            console.log('attach', currentElement, commentNode);
+            neverAttached = false;
             if (!currentElement) {
               $transclude(function(elm, newScope) {
+                console.log('newScope', newScope.$id, elm);
                 $animate.enter(elm, null, element);
                 currentElement = elm;
 
@@ -702,6 +706,7 @@ function ngMessageDirectiveFactory() {
                 // by another structural directive then it's time
                 // to deregister the message from the controller
                 currentElement.on('$destroy', function() {
+                  console.log('element destroy', currentElement);
                   if (currentElement && currentElement.$$attachId === $$attachId) {
                     ngMessagesCtrl.deregister(commentNode);
                     messageCtrl.detach();
@@ -713,12 +718,22 @@ function ngMessageDirectiveFactory() {
           },
           detach: function() {
             if (currentElement) {
+              console.log('detach', currentElement);
               var elm = currentElement;
               currentElement = null;
               $animate.leave(elm);
             }
           }
         });
+
+        console.log('setup destroy', scope.$id, commentNode);
+        scope.$on('$destroy', function() {
+          console.log('scope destroy', scope.$id, commentNode, currentElement);
+          if (neverAttached) {
+            console.log('never attached destroy', scope.$id, commentNode, currentElement);
+            ngMessagesCtrl.deregister(commentNode);
+          }
+        });
       }
     };
   }];

test/helpers/testabilityPatch.js

@@ -65,7 +65,7 @@ afterEach(function() {
         if (value && value.$element) {
           dump('LEAK', key, value.$id, sortedHtml(value.$element));
         } else {
-          dump('LEAK', key, angular.toJson(value));
+          dump('LEAK', key, value, value.$parent);
         }
       });
     });

test/ngMessages/messagesSpec.js

@@ -1,6 +1,6 @@
 'use strict';
 
-describe('ngMessages', function() {
+fdescribe('ngMessages', function() {
   beforeEach(inject.strictDi());
   beforeEach(module('ngMessages'));
 
@@ -491,7 +491,7 @@ describe('ngMessages', function() {
 
   describe('ngMessage nested nested inside elements', function() {
 
-    it('should not crash or leak memory when the messages are transcluded, the first message is ' +
+    fit('should not crash or leak memory when the messages are transcluded, the first message is ' +
       'visible, and ngMessages is removed by ngIf', function() {
 
       module(function($compileProvider) {
@@ -636,6 +636,43 @@ describe('ngMessages', function() {
     })
   );
 
+  fit('should unregister the ngMessage even if it was never attached',
+    inject(function($compile, $rootScope) {
+      var html =
+        '<div ng-messages="items">' +
+          '<div ng-if="show"><div ng-message="x">ERROR</div></div>' +
+        '</div>';
+
+      element = $compile(html)($rootScope);
+
+      var ctrl = element.controller('ngMessages');
+
+      $rootScope.$apply('show = true');
+      expect(messageChildren(element).length).toBe(0);
+      expect(Object.keys(ctrl.messages).length).toEqual(1);
+
+      $rootScope.$apply('show = false');
+      expect(messageChildren(element).length).toBe(0);
+      expect(Object.keys(ctrl.messages).length).toEqual(0);
+
+      // $rootScope.$apply('show = true');
+      // expect(messageChildren(element).length).toBe(0);
+      // expect(Object.keys(ctrl.messages).length).toEqual(1);
+
+      // $rootScope.$apply('show = false');
+      // expect(messageChildren(element).length).toBe(0);
+      // expect(Object.keys(ctrl.messages).length).toEqual(0);
+
+      // $rootScope.$apply('show = true');
+      // expect(messageChildren(element).length).toBe(0);
+      // expect(Object.keys(ctrl.messages).length).toEqual(1);
+
+      // $rootScope.$apply('show = false');
+      // expect(messageChildren(element).length).toBe(0);
+      // expect(Object.keys(ctrl.messages).length).toEqual(0);
+    })
+  );
+
 
   describe('when including templates', function() {
     they('should work with a dynamic collection model which is managed by ngRepeat',