chore(*): silence ng-closure-runner warnings during grunt minall

Author: gkalpak

src/.eslintrc.json

@@ -115,6 +115,7 @@
 
     /* minErr.js */
     "minErr": false,
+    "noMinErr": false,
 
     /* loader.js */
     "setupModuleLoader": false,

src/auto/injector.js

@@ -824,7 +824,7 @@ function createInjector(modulesToLoad, strictDi) {
           if (cache[serviceName] === INSTANTIATING) {
             delete cache[serviceName];
           }
-          throw err;
+          throw noMinErr('', '', err);
         } finally {
           path.shift();
         }

src/minErr.js

@@ -29,7 +29,6 @@
  *   error from returned function, for cases when a particular type of error is useful.
  * @returns {function(code:string, template:string, ...templateArgs): Error} minErr instance
  */
-
 function minErr(module, ErrorConstructor) {
   ErrorConstructor = ErrorConstructor || Error;
   return function() {
@@ -63,3 +62,38 @@ function minErr(module, ErrorConstructor) {
     return new ErrorConstructor(message);
   };
 }
+
+/**
+ * @description
+ *
+ * In certain case (e.g. when catching and rethrowing an error), it is neither desirable nor
+ * necessary to pass the error through `minErr()`. You can use this function to avoid warnings
+ * produced by `ng-closire-runner` during `grunt minall`.
+ *
+ * Due to what arguments `ng-closure-runner` expects, the first two arguments must be static
+ * strings. Therefore, you have to pass the actual error as 3rd argument (see example below).
+ *
+ * **WARNING**
+ * Only use this function when you are certain that the thrown error should NOT be a `minErr`
+ * instance;
+ *
+ * Example usage:
+ *
+ * ```js
+ * try {
+ *   tryAndFail();
+ * } catch (err) {
+ *   doSomeThing(err);
+ *   throw noMinErr('', '', err);   // Functionally equivalent to `throw err`,
+ *                                  // but avoids `ng-closuer-runner` warnings.
+ * }
+ * ```
+ *
+ * @param {string} ignoredCode - Ignored, but necessary for `ng-closure-runner`.
+ * @param {string} ignoredTemplate - Ignored, but necessary for `ng-closure-runner`.
+ * @param {*} error - The error object that will be returned.
+ * @returns {*} - The passed in error.
+ */
+function noMinErr(ignoredCode, ignoredTemplate, err) {
+  return err;
+}

src/ng/compile.js

@@ -1525,7 +1525,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
           // Reset the queue to trigger a new schedule next time there is a change
           onChangesQueue = undefined;
           if (errors.length) {
-            throw errors;
+            throw noMinErr('', '', errors);
           }
         });
       } finally {

src/ng/directive/ngModelOptions.js

@@ -41,7 +41,7 @@ ModelOptions.prototype = {
     options = extend({}, options);
 
     // Inherit options from the parent if specified by the value `"$inherit"`
-    forEach(options, /* @this */ function(option, key) {
+    forEach(options, /** @this */ function(option, key) {
       if (option === '$inherit') {
         if (key === '*') {
           inheritAll = true;

src/ng/httpBackend.js

@@ -136,7 +136,7 @@ function createHttpBackend($browser, createXhr, $browserDefer, callbacks, rawDoc
           // The json response type can be ignored if not supported, because JSON payloads are
           // parsed on the client-side regardless.
           if (responseType !== 'json') {
-            throw e;
+            throw noMinErr('', '', e);
           }
         }
       }

src/ng/location.js

@@ -871,7 +871,7 @@ function $LocationProvider() {
         $location.url(oldUrl);
         $location.$$state = oldState;
 
-        throw e;
+        throw noMinErr('', '', e);
       }
     }
 

src/ng/rootScope.js

@@ -1082,7 +1082,7 @@ function $RootScopeProvider() {
           } catch (e) {
             $exceptionHandler(e);
             // eslint-disable-next-line no-unsafe-finally
-            throw e;
+            throw noMinErr('', '', e);
           }
         }
       },

test/.eslintrc.json

@@ -113,6 +113,7 @@
 
     /* minerr.js */
     "minErr": false,
+    "noMinErr": false,
 
     /* loader.js */
     "setupModuleLoader": false,

test/minErrSpec.js

@@ -105,3 +105,13 @@ describe('minErr', function() {
       .toMatch(/^[\s\S]*\?p0=a&p1=b&p2=value%20with%20space$/);
   });
 });
+
+describe('noMinErr', function() {
+  it('should return the 3rd argument', function() {
+    expect(noMinErr('foo', 'bar', 'baz')).toBe('baz');
+    expect(noMinErr('foo', 'bar', null)).toBe(null);
+    expect(noMinErr('foo', 'bar')).toBeUndefined();
+    expect(noMinErr('foo')).toBeUndefined();
+    expect(noMinErr()).toBeUndefined();
+  });
+});