fix(ngModelController): don't run $validators if modelValue hasn't changed

This fixes issues where a parser calls $setViewValue. This is a common
strategy for manipulating the $viewValue while the user is entering
data into an input field.

When the $viewValue was changed inside the parser, the new viewValue
would be committed and used for validation. The original parser
however would run last and pass the original (outdated) viewValue on
to the validators, which could cause false positives, e.g. for
minlength.

Author: Narretz

src/ng/directive/input.js

@@ -2198,12 +2198,22 @@ var NgModelController = ['$scope', '$exceptionHandler', '$attrs', '$element', '$
       ctrl.$modelValue = ngModelGet($scope);
     }
     var prevModelValue = ctrl.$modelValue;
-    var allowInvalid = ctrl.$options && ctrl.$options.allowInvalid;
     ctrl.$$rawModelValue = modelValue;
+
+    //If the modelValue hasn't changed since last parsing, there is no need to
+    //update or validate again
+    //This can happen if $setViewValue is called from inside a parser
+    if (angular.isDefined(modelValue) && prevModelValue === modelValue) {
+      return;
+    }
+
+    var allowInvalid = ctrl.$options && ctrl.$options.allowInvalid;
+
     if (allowInvalid) {
       ctrl.$modelValue = modelValue;
       writeToModelIfNeeded();
     }
+
     ctrl.$$runValidators(parserValid, modelValue, viewValue, function(allValid) {
       if (!allowInvalid) {
         // Note: Don't check ctrl.$valid here, as we could have

test/ng/directive/inputSpec.js

@@ -1066,6 +1066,31 @@ describe('NgModelController', function() {
 
       dealoc(element);
     }));
+
+
+    it('should not run $validators if the modelValue did not change', function() {
+      ctrl.$parsers.push(function(value) {
+        if (value && value.substr(-1) === 'b') {
+          value = 'a';
+          ctrl.$setViewValue(value);
+          ctrl.$render();
+        }
+
+        return value;
+      });
+
+      ctrl.$validators.mock = function(modelValue) {
+        return true;
+      };
+
+      spyOn(ctrl.$validators, 'mock').andCallThrough();
+      spyOn(ctrl, '$commitViewValue').andCallThrough();
+
+      ctrl.$setViewValue('ab');
+
+      expect(ctrl.$commitViewValue.calls.length).toEqual(2);
+      expect(ctrl.$validators.mock).toHaveBeenCalledOnceWith('a', 'a');
+    });
   });
 });