[WIP] lint benchmarks

Author: mgol

.eslintignore

@@ -9,6 +9,3 @@ src/angular.bind.js
 src/ngParseExt/ucd.js
 i18n/closure/**
 tmp/**
-
-# TODO start linting those files?
-benchmarks/**

Gruntfile.js

@@ -119,6 +119,7 @@ module.exports = function(grunt) {
       all: {
         src: [
           '*.js',
+          'benchmarks/**/*.js',
           'docs/**/*.js',
           'lib/**/*.js',
           'scripts/**/*.js',

benchmarks/.eslintrc

@@ -0,0 +1,8 @@
+{
+  "globals": {
+    "window": false,
+
+    "angular": false,
+    "benchmarkSteps": false
+  }
+}

benchmarks/event-delegation-bp/app.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var app = angular.module('eventDelegationBenchmark', []);
 
 app.directive('noopDir', function() {
@@ -13,7 +15,7 @@ app.directive('noopDir', function() {
 app.directive('nativeClick', ['$parse', function($parse) {
   return {
     compile: function($element, $attrs) {
-      var expr = $parse($attrs.tstEvent);
+      $parse($attrs.tstEvent);
       return function($scope, $element) {
         $element[0].addEventListener('click', function() {
           console.log('clicked');
@@ -26,13 +28,12 @@ app.directive('nativeClick', ['$parse', function($parse) {
 app.directive('dlgtClick', function() {
   return {
     compile: function($element, $attrs) {
-      var evt = $attrs.dlgtClick;
       // We don't setup the global event listeners as the costs are small and one time only...
     }
   };
 });
 
-app.controller('DataController', function($rootScope) {
+app.controller('DataController', function DataController($rootScope) {
   this.ngRepeatCount = 1000;
   this.rows = [];
   var self = this;

benchmarks/event-delegation-bp/bp.conf.js

@@ -1,9 +1,11 @@
+'use strict';
+
 module.exports = function(config) {
   config.set({
     scripts: [{
       id: 'angular',
       src: '/build/angular.js'
-    },{
+    }, {
       src: 'app.js'
     }]
   });

benchmarks/largetable-bp/app.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var app = angular.module('largetableBenchmark', []);
 
 app.config(function($compileProvider) {
@@ -12,7 +14,7 @@ app.filter('noop', function() {
   };
 });
 
-app.controller('DataController', function($scope, $rootScope) {
+app.controller('DataController', function DataController($scope, $rootScope) {
   var totalRows = 1000;
   var totalColumns = 20;
 
@@ -21,7 +23,9 @@ app.controller('DataController', function($scope, $rootScope) {
   $scope.numberOfBindings = totalRows * totalColumns * 2 + totalRows + 1;
   $scope.numberOfWatches = '?';
 
+  /* @this DataController */
   function iGetter() { return this.i; }
+  /* @this DataController */
   function jGetter() { return this.j; }
 
   for (var i = 0; i < totalRows; i++) {
@@ -64,14 +68,13 @@ app.controller('DataController', function($scope, $rootScope) {
   });
 });
 
-var fn = function() { return 'x';};
-
 
 app.directive('baselineBindingTable', function() {
   return {
     restrict: 'E',
     link: function($scope, $element) {
       var i, j, row, cell, comment;
+      var document = window.document;
       var template = document.createElement('span');
       template.setAttribute('ng-repeat', 'foo in foos');
       template.classList.add('ng-scope');
@@ -106,6 +109,7 @@ app.directive('baselineInterpolationTable', function() {
     restrict: 'E',
     link: function($scope, $element) {
       var i, j, row, cell, comment;
+      var document = window.document;
       var template = document.createElement('span');
       template.setAttribute('ng-repeat', 'foo in foos');
       template.classList.add('ng-scope');

benchmarks/largetable-bp/bp.conf.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = function(config) {
   config.set({
     scripts: [{

benchmarks/ng-options-bp/bp.conf.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = function(config) {
   config.set({
     scripts: [{

benchmarks/orderby-bp/app.js

@@ -1,6 +1,8 @@
+'use strict';
+
 var app = angular.module('orderByBenchmark', []);
 
-app.controller('DataController', function($rootScope, $scope) {
+app.controller('DataController', function DataController($rootScope, $scope) {
   this.ngRepeatCount = 5000;
   this.rows = [];
   var self = this;

benchmarks/orderby-bp/bp.conf.js

@@ -1,13 +1,15 @@
+'use strict';
+
 module.exports = function(config) {
   config.set({
     scripts: [
     {
       "id": "jquery",
       "src": "jquery-noop.js"
-    },{
+    }, {
       id: 'angular',
       src: '/build/angular.js'
-    },{
+    }, {
       src: 'app.js'
     }]
   });

benchmarks/parsed-expressions-bp/app.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var app = angular.module('parsedExpressionBenchmark', []);
 
 app.config(function($compileProvider) {

benchmarks/parsed-expressions-bp/bp.conf.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = function(config) {
   config.set({
     scripts: [{

benchmarks/select-ng-value-bp/bp.conf.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = function(config) {
   config.set({
     scripts: [{

src/ngMock/.eslintrc.json

@@ -1,7 +1,4 @@
 {
-  "rules": {
-    "eqeqeq": "off" // TODO enable?
-  },
   "globals": {
     "window": false,
 

src/ngMock/angular-mocks.js

@@ -1920,7 +1920,7 @@ function MockHttpExpectation(method, url, data, headers, keys) {
   this.headers = headers;
 
   this.match = function(m, u, d, h) {
-    if (method != m) return false;
+    if (method !== m) return false;
     if (!this.matchUrl(u)) return false;
     if (angular.isDefined(d) && !this.matchData(d)) return false;
     if (angular.isDefined(h) && !this.matchHeaders(h)) return false;
@@ -2895,7 +2895,7 @@ angular.mock.$RootScopeDecorator = ['$delegate', function($delegate) {
   };
 
   module.$$beforeEach = function() {
-    if (injectorState.shared && currentSpec && currentSpec != this) {
+    if (injectorState.shared && currentSpec && currentSpec !== this) {
       var state = currentSpec;
       currentSpec = this;
       angular.forEach(["$injector","$modules","$providerInjector", "$injectorStrict"], function(k) {