fix(ngStyle): clear the style even when newStyle has the property but falsy

itchyny · itchyny · commit 5d74f0f2884f · 2018-10-02T20:47:45.000+09:00
diff --git a/src/ng/directive/ngStyle.js b/src/ng/directive/ngStyle.js
@@ -55,7 +55,7 @@ var ngStyleDirective = ngDirective(function(scope, element, attr) {
   scope.$watchCollection(attr.ngStyle, function ngStyleWatchAction(newStyles, oldStyles) {
     if (oldStyles && (newStyles !== oldStyles)) {
       forEach(oldStyles, function(val, style) {
-        if (!(newStyles && newStyles.hasOwnProperty(style))) {
+        if (!(newStyles && newStyles[style])) {
           element.css(style, '');
         }
       });

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ var ngStyleDirective = ngDirective(function(scope, element, attr) {`
`55`	`55`	`scope.$watchCollection(attr.ngStyle, function ngStyleWatchAction(newStyles, oldStyles) {`
`56`	`56`	`if (oldStyles && (newStyles !== oldStyles)) {`
`57`	`57`	`forEach(oldStyles, function(val, style) {`
`58`		`- if (!(newStyles && newStyles.hasOwnProperty(style))) {`
	`58`	`+ if (!(newStyles && newStyles[style])) {`
`59`	`59`	`element.css(style, '');`
`60`	`60`	`}`
`61`	`61`	`});`