chore(benchmarks): remove no longer applicable tests and literal watching workarounds

Author: jbedard

benchmarks/parsed-expressions-bp/app.js

@@ -29,24 +29,6 @@ app.directive('bmPeWatch', function() {
   };
 });
 
-//Executes the specified expression as a watcher
-//Adds a simple wrapper method to allow use of $watch instead of $watchCollection
-app.directive('bmPeWatchLiteral', function($parse) {
-  function retZero() {
-    return 0;
-  }
-
-  return {
-    restrict: 'A',
-    compile: function($element, $attrs) {
-      $element.text($attrs.bmPeWatchLiteral);
-      return function($scope, $element, $attrs) {
-        $scope.$watch($parse($attrs.bmPeWatchLiteral, retZero));
-      };
-    }
-  };
-});
-
 app.controller('DataController', function($scope, $rootScope) {
   var totalRows = 10000;
 
@@ -72,8 +54,7 @@ app.controller('DataController', function($scope, $rootScope) {
       date2: new Date(Math.random() * Date.now()),
       func: function() { return star; },
       obj: data[i - 1],
-      keys: data[i - 1] && (data[i - 1].keys || Object.keys(data[i - 1])),
-      constructor: data[i - 1]
+      keys: data[i - 1] && (data[i - 1].keys || Object.keys(data[i - 1]))
     });
   }
 

benchmarks/parsed-expressions-bp/main.html

@@ -16,12 +16,6 @@
           <label for="complexPath">Complex Paths</label>
         </li>
 
-        <li>
-          <input type="radio" ng-model="expressionType" value="constructorPath" id="constructorPath">
-          <label for="constructorPath">Constructor Paths</label>
-          ($parse special cases "constructor" for security)
-        </li>
-
         <li>
           <input type="radio" ng-model="expressionType" value="fieldAccess" id="fieldAccess">
           <label for="fieldAccess">Field Accessors</label>
@@ -88,17 +82,6 @@
           <span bm-pe-watch="row.keys"></span>
         </li>
 
-        <li ng-switch-when="constructorPath" ng-repeat="(rowIdx, row) in ::data">
-          <span bm-pe-watch="row.index"></span>
-          <span bm-pe-watch="row.constructor.index"></span>
-          <span bm-pe-watch="row.constructor.index"></span>
-          <span bm-pe-watch="row.constructor.index"></span>
-          <span bm-pe-watch="row.constructor.constructor.index"></span>
-          <span bm-pe-watch="row.constructor.constructor.index"></span>
-          <span bm-pe-watch="row.constructor.constructor.constructor.index"></span>
-          <span bm-pe-watch="row.constructor.constructor.constructor.index"></span>
-        </li>
-
         <li ng-switch-when="complexPath" ng-repeat="(rowIdx, row) in ::data">
           <span bm-pe-watch="row.index"></span>
           <span bm-pe-watch="row.num0"></span>
@@ -215,27 +198,27 @@
         </li>
 
         <li ng-switch-when="objectLiterals" ng-repeat="(rowIdx, row) in ::data">
-          <span bm-pe-watch-literal="{foo: rowIdx}"></span>
-          <span bm-pe-watch-literal="{foo: row, bar: rowIdx}"></span>
-          <span bm-pe-watch-literal="{0: row, 1: rowIdx, 2: 3}"></span>
-          <span bm-pe-watch-literal="{str: 'foo', num: rowIdx, b: true}"></span>
-          <span bm-pe-watch-literal="{a: {b: {c: {d: {e: {f: rowIdx}}}}}}"></span>
-          <span bm-pe-watch-literal="{a: rowIdx, b: 1, c: 2, d: 3, e: 4, f: 5, g: rowIdx, h: 6, i: 7, j: 8, k: rowIdx}"></span>
+          <span bm-pe-watch="{foo: rowIdx}"></span>
+          <span bm-pe-watch="{foo: row, bar: rowIdx}"></span>
+          <span bm-pe-watch="{0: row, 1: rowIdx, 2: 3}"></span>
+          <span bm-pe-watch="{str: 'foo', num: rowIdx, b: true}"></span>
+          <span bm-pe-watch="{a: {b: {c: {d: {e: {f: rowIdx}}}}}}"></span>
+          <span bm-pe-watch="{a: rowIdx, b: 1, c: 2, d: 3, e: 4, f: 5, g: rowIdx, h: 6, i: 7, j: 8, k: rowIdx}"></span>
         </li>
 
         <li ng-switch-when="arrayLiterals" ng-repeat="(rowIdx, row) in ::data">
-          <span bm-pe-watch-literal="[rowIdx]"></span>
-          <span bm-pe-watch-literal="[rowIdx, 0]"></span>
-          <span bm-pe-watch-literal="[rowIdx, 0, 1]"></span>
-          <span bm-pe-watch-literal="[rowIdx, 0, 1, 2]"></span>
-          <span bm-pe-watch-literal="[rowIdx, 0, 1, 2, 3]"></span>
-          <span bm-pe-watch-literal="[[], [rowIdx], [], [], [3], [[[]]]]"></span>
-          <span bm-pe-watch-literal="[rowIdx, undefined, null, true, false]"></span>
-          <span bm-pe-watch-literal="[[][0], [0][0], [][rowIdx]]"></span>
-          <span bm-pe-watch-literal="[0, rowIdx]"></span>
-          <span bm-pe-watch-literal="[0, 1, rowIdx]"></span>
-          <span bm-pe-watch-literal="[0, 1, 2, rowIdx]"></span>
-          <span bm-pe-watch-literal="[0, 1, 2, 3, rowIdx]"></span>
+          <span bm-pe-watch="[rowIdx]"></span>
+          <span bm-pe-watch="[rowIdx, 0]"></span>
+          <span bm-pe-watch="[rowIdx, 0, 1]"></span>
+          <span bm-pe-watch="[rowIdx, 0, 1, 2]"></span>
+          <span bm-pe-watch="[rowIdx, 0, 1, 2, 3]"></span>
+          <span bm-pe-watch="[[], [rowIdx], [], [], [3], [[[]]]]"></span>
+          <span bm-pe-watch="[rowIdx, undefined, null, true, false]"></span>
+          <span bm-pe-watch="[[][0], [0][0], [][rowIdx]]"></span>
+          <span bm-pe-watch="[0, rowIdx]"></span>
+          <span bm-pe-watch="[0, 1, rowIdx]"></span>
+          <span bm-pe-watch="[0, 1, 2, rowIdx]"></span>
+          <span bm-pe-watch="[0, 1, 2, 3, rowIdx]"></span>
         </li>
       </ul>
     </div>