Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 3f95ae2

Browse files
committed
chore(code.angularjs.org): resolve gcs file stream on 'finish'
'response' is called before the data transfer is complete.
1 parent 00b482f commit 3f95ae2

File tree

1 file changed

+3
-7
lines changed
  • scripts/code.angularjs.org-firebase/functions

1 file changed

+3
-7
lines changed

scripts/code.angularjs.org-firebase/functions/index.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,8 @@ function sendStoredFile(request, response) {
6161
return new Promise((resolve, reject) => {
6262

6363
const readStream = file.createReadStream()
64-
.on('error', error => {
65-
reject(error);
66-
})
67-
.on('response', () => {
68-
resolve(response);
69-
});
64+
.on('error', reject)
65+
.on('finish', resolve);
7066

7167
response
7268
.status(200)
@@ -75,7 +71,7 @@ function sendStoredFile(request, response) {
7571
'Cache-Control': `public, max-age=${BROWSER_CACHE_DURATION}, s-maxage=${CDN_CACHE_DURATION}`
7672
});
7773

78-
readStream.pipe(response);
74+
readStream.pipe(response);
7975
});
8076

8177
});

0 commit comments

Comments
 (0)