perf($compile): wrap try/catch of collect comment directives into a function to avoid V8 deopt

Author: drpicox

src/ng/compile.js

@@ -2052,24 +2052,30 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
           addTextInterpolateDirective(directives, node.nodeValue);
           break;
         case NODE_TYPE_COMMENT: /* Comment */
-          try {
-            match = COMMENT_DIRECTIVE_REGEXP.exec(node.nodeValue);
-            if (match) {
-              nName = directiveNormalize(match[1]);
-              if (addDirective(directives, nName, 'M', maxPriority, ignoreDirective)) {
-                attrs[nName] = trim(match[2]);
-              }
-            }
-          } catch (e) {
-            // turns out that under some circumstances IE9 throws errors when one attempts to read
-            // comment's node value.
-            // Just ignore it and continue. (Can't seem to reproduce in test case.)
-          }
+          collectCommentDirectives();
           break;
       }
 
       directives.sort(byPriority);
       return directives;
+
+      function collectCommentDirectives() {
+        // function created because of performance, try/catch disables
+        // the optimization of the whole function #14848
+        try {
+          match = COMMENT_DIRECTIVE_REGEXP.exec(node.nodeValue);
+          if (match) {
+            nName = directiveNormalize(match[1]);
+            if (addDirective(directives, nName, 'M', maxPriority, ignoreDirective)) {
+              attrs[nName] = trim(match[2]);
+            }
+          }
+        } catch (e) {
+          // turns out that under some circumstances IE9 throws errors when one attempts to read
+          // comment's node value.
+          // Just ignore it and continue. (Can't seem to reproduce in test case.)
+        }
+      }
     }
 
     /**