Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 25f49ad

Browse files
committed
fix(ngTouch): remove ngClick override and $touchProvider.ngClickOverrideEnabled()
Closes #15755 BREAKING CHANGE: The `ngClick` directive from the ngTouch module has been removed, and with the also the corresponding $touchProvider.ngClickOverrideEnabled() method. If you have included ngTouch in your application with a version of 1.5.0 or higher, and have not changed the value of $touchProvider.ngClickOverrideEnabled()`, then there are no migration steps. The `ngClick` override directive had been deprecated and by default disabled since v1.5.0, because of buggy behavior in edge cases, and a general trend to avoid special touch based overrides of click events. If you still need a touch override, consider using [Fastclick](https://github.com/ftlabs/fastclick). Note that the `$touch` service still offers the `ngClickOverrideEnabled()` function for libraries that want to detect if an app uses the click override. Starting with 1.7.0, it will always return `false`.
1 parent 4d43ee3 commit 25f49ad

File tree

5 files changed

+11
-1121
lines changed

5 files changed

+11
-1121
lines changed

angularFiles.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ var angularFiles = {
146146
'ngTouch': [
147147
'src/ngTouch/touch.js',
148148
'src/ngTouch/swipe.js',
149-
'src/ngTouch/directive/ngClick.js',
150149
'src/ngTouch/directive/ngSwipe.js'
151150
],
152151
'ngAria': [

docs/content/misc/downloading.ngdoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ The set of files included in each version directory are:
111111
* __`angular-route.js`__ — Routing and deep-linking services and directives for AngularJS apps.
112112
({@link module:ngRoute API docs})
113113
* __`angular-sanitize.js`__ — Functionality to sanitize HTML. ({@link module:ngSanitize API docs})
114-
* __`angular-touch.js`__ — Touch events and other helpers for touch-enabled devices.
114+
* __`angular-touch.js`__ — Touch events for touch-enabled devices.
115115
({@link module:ngTouch API docs})
116116

117117

src/ngTouch/directive/ngClick.js

Lines changed: 0 additions & 298 deletions
This file was deleted.

0 commit comments

Comments
 (0)