chore(doc-gen): include source files from code.angularjs.org for production plnkr examples

Author: Narretz

docs/app/e2e/app.scenario.js

@@ -49,6 +49,25 @@ describe('docs.angularjs.org', function() {
     });
 
 
+    it('should include the files for the embedded examples from the same domain', function() {
+      browser.get('build/docs/index-production.html#!api/ng/directive/ngClick');
+
+      var origin = browser.executeScript('return document.location.origin;');
+
+      var exampleIFrame = element(by.name('example-ng-click'));
+
+      // This is technically an implementation detail, but if this changes, then there's a good
+      // chance the deployment process changed
+      expect(exampleIFrame.getAttribute('src')).toContain('examples/example-ng-click/index.html');
+
+      browser.switchTo().frame('example-ng-click');
+
+      var scriptEl = element(by.tagName('script'));
+
+      // Ensure the included file is from the same domain
+      expect(scriptEl.getAttribute('src')).toContain(origin);
+    });
+
 
     it('should be resilient to trailing slashes', function() {
       browser.get('build/docs/index-production.html#!/api/ng/function/angular.noop/');

docs/config/services/deployments/production.js

@@ -7,15 +7,15 @@ var angularCodeUrl = '//code.angularjs.org/';
 
 var cdnUrl = googleCdnUrl + versionInfo.cdnVersion;
 
-// The plnkr examples must use the code.angularjs.org repo for the snapshot,
-// and the cdn for the tagged version and, if the build is not tagged, the currentVersion.
-//
-// The currentVersion may not be available on the cdn (e.g. if built locally, or hasn't been pushed
-// yet). This will lead to a 404, but this is preferable to loading a version with which the example
-// might not work (possibly in subtle ways).
+// The "examplesCdnUrl" here applies to the examples when they are opened in plnkr.co.
+// The embedded examples instead always include the files from the *default* deployment,
+// to ensure that the source files are always available.
+// The plnkr examples must always use the code.angularjs.org source files.
+// We cannot rely on the CDN files here, because they are not deployed during the same time
+// as the docs app.
 var examplesCdnUrl = versionInfo.currentVersion.isSnapshot ?
   (angularCodeUrl + 'snapshot') :
-  (googleCdnUrl + (versionInfo.currentVersion.version || versionInfo.currentVersion));
+  (angularCodeUrl + (versionInfo.currentVersion.version || versionInfo.currentVersion.version));
 
 module.exports = function productionDeployment(getVersion) {
   return {
@@ -24,7 +24,7 @@ module.exports = function productionDeployment(getVersion) {
       commonFiles: {
         scripts: [examplesCdnUrl + '/angular.min.js']
       },
-      dependencyPath: examplesCdnUrl + '/'
+      dependencyPath: examplesCdnUrl
     },
     scripts: [
       cdnUrl + '/angular.min.js',