remove cruft, remove selected from empty option

Author: Narretz

src/ng/directive/ngOptions.js

@@ -475,6 +475,7 @@ var ngOptionsDirective = ['$compile', '$document', '$parse', function($compile,
           if (selectedOption) selectedOption.element.removeAttribute('selected');
 
           if (option) {
+            if (providedEmptyOption) emptyOption.removeAttr('selected');
             // Don't update the option when it is already selected.
             // For example, the browser will select the first option by default. In that case,
             // most properties are set automatically - except the `selected` attribute, which we

test/ng/directive/ngOptionsSpec.js

@@ -743,6 +743,7 @@ describe('ngOptions', function() {
     expect(options.eq(3)).toEqualOption('c');
   });
 
+
   it('should remove the "selected" attribute from the previous option when the model changes', function() {
     scope.values = [{id: 10, label: 'ten'}, {id:20, label: 'twenty'}];
 
@@ -751,18 +752,22 @@ describe('ngOptions', function() {
       'ng-options': 'item.label for item in values'
     }, true);
 
-    var resetButton = angular.element('<input type="reset" />');
-    formElement.append(resetButton);
+    var options = element.find('option');
+    expect(options[0].getAttribute('selected')).toBe('selected');
+    expect(options[1].hasAttribute('selected')).toBe(false);
+    expect(options[2].hasAttribute('selected')).toBe(false);
 
     scope.selected = scope.values[0];
     scope.$digest();
 
-    var options = element.find('option');
+    expect(options[0].hasAttribute('selected')).toBe(false);
     expect(options[1].getAttribute('selected')).toBe('selected');
+    expect(options[2].hasAttribute('selected')).toBe(false);
 
     scope.selected = scope.values[1];
     scope.$digest();
 
+    expect(options[0].hasAttribute('selected')).toBe(false);
     expect(options[1].hasAttribute('selected')).toBe(false);
     expect(options[2].getAttribute('selected')).toBe('selected');
 
@@ -1441,7 +1446,6 @@ describe('ngOptions', function() {
       scope.selected = {};
       scope.$digest();
 
-      options[2].selected = false;
       expect(options[0].selected).toBe(true);
       expect(options[0].getAttribute('selected')).toBe('selected');
       expect(options[2].selected).toBe(false);