[WIP] code review

Author: mgol

.eslintignore

@@ -1,7 +1,7 @@
 bower_components/**
 build/**
 docs/bower_components/**
-docs/app/assets/**
+docs/app/assets/js/angular-bootstrap/**
 docs/config/templates/**
 node_modules/**
 lib/htmlparser/**

docs/app/assets/js/search-worker.js

@@ -8,7 +8,7 @@ importScripts('../components/lunr.js-0.5.12/lunr.min.js');
 
 // Create the lunr index - the docs should be an array of object, each object containing
 // the path and search terms for a page
-var index = lunr(function() {
+var index = lunr(/* @this */function() {
   this.ref('path');
   this.field('titleWords', {boost: 50});
   this.field('members', {boost: 40});

docs/app/src/examples.js

@@ -2,7 +2,7 @@
 
 angular.module('examples', [])
 
-.directive('runnableExample', ['$templateCache', '$document', function($templateCache, $document) {
+.directive('runnableExample', [function() {
   var exampleClassNameSelector = '.runnable-example-file';
   var tpl =
     '<nav class="runnable-example-tabs" ng-if="tabs">' +

docs/app/src/search.js

@@ -32,11 +32,7 @@ angular.module('search', [])
           }
         });
 
-        var totalAreas = 0;
-        // eslint-disable-next-line no-unused-vars
-        for (var i in results) {
-          ++totalAreas;
-        }
+        var totalAreas = Object.keys(results).length;
         if (totalAreas > 0) {
           $scope.colClassName = 'cols-' + totalAreas;
         }

docs/content/guide/component.ngdoc

@@ -388,7 +388,7 @@ Here is a tab pane example built from components:
 angular.module('docsTabsExample', [])
   .component('myTabs', {
     transclude: true,
-    controller: function Controller() {
+    controller: function MyTabsController() {
       var panes = this.panes = [];
       this.select = function(pane) {
         angular.forEach(panes, function(pane) {

docs/content/guide/decorators.ngdoc

@@ -354,9 +354,8 @@ those conditions.
               var exps = matchExpressions(originalExp);
 
               // create and store the getters using $parse
-              var getters = exps.map(function(el) {
-                if (el) return $parse(el);
-                return undefined;
+              var getters = exps.map(function(exp) {
+                return exp && $parse(exp);
               });
 
               return function newLinkFn(scope, elem, attr) {

docs/content/guide/directive.ngdoc

@@ -856,7 +856,7 @@ to which tab is active.
           restrict: 'E',
           transclude: true,
           scope: {},
-          controller: ['$scope', function Controller($scope) {
+          controller: ['$scope', function MyTabsController($scope) {
             var panes = $scope.panes = [];
 
             $scope.select = function(pane) {

docs/gulpfile.js

@@ -1,4 +1,4 @@
-"use strict";
+'use strict';
 
 var gulp = require('gulp');
 var log = require('gulp-util').log;
@@ -124,7 +124,7 @@ gulp.task('eslint', ['doc-gen'], function() {
   var examplesConfig = getMergedEslintConfig('../docs/app/test/.eslintrc.json');
 
   var protractorConfig = getMergedEslintConfig('../docs/app/e2e/.eslintrc.json');
-  protractorConfig.rules['no-unused-vars'] = ["error", {
+  protractorConfig.rules['no-unused-vars'] = ['error', {
     vars: 'local',
     args: 'none',
     // This variable is declared in code generated by dgeni-packages

i18n/spec/utilSpec.js

@@ -65,9 +65,8 @@ function extractDateTimeSymbols(content, localeInfo) {
   for (var propName in goog.i18n) {
     var localeID = findLocaleId(propName, 'datetime');
     if (localeID) {
-      // eslint-disable-next-line no-unused-vars
       var info = getInfoForLocale(localeInfo, localeID);
-      localeInfo[localeID].DATETIME_FORMATS =
+      info.DATETIME_FORMATS =
           converter.convertDatetimeData(goog.i18n[propName]);
     }
   }