Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Commit f8e6b5d

Browse files
chalinkwalrath
authored andcommitted
docs(toh-5/dart): make dashboard more robust (#1688)
Originally the dashboard TS expression ``heroes.slice(1, 5))` had been written as: > _heroService.getHeroes().getRange(1, 5) which is brittle; it fails if there are not enough heroes. Slice doesn't fail; an equivalent express ion in Dart is > _heroService.getHeroes().skip(1).take(4) This is now used. Other changes: - Fix in css (missed TS-side update). - Ran `dartfmt` on `heroes_component.dart`.
1 parent eda47f6 commit f8e6b5d

File tree

6 files changed

+15
-13
lines changed

6 files changed

+15
-13
lines changed

public/docs/_examples/toh-5/dart/lib/dashboard_component.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class DashboardComponent implements OnInit {
3232
// #enddocregion ctor
3333

3434
Future<Null> ngOnInit() async {
35-
heroes = (await _heroService.getHeroes()).getRange(1, 5).toList();
35+
heroes = (await _heroService.getHeroes()).skip(1).take(4).toList();
3636
}
3737

3838
// #docregion goto-detail

public/docs/_examples/toh-5/dart/lib/dashboard_component_2.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class DashboardComponent implements OnInit {
1919
DashboardComponent(this._heroService);
2020

2121
Future<Null> ngOnInit() async {
22-
heroes = (await _heroService.getHeroes()).getRange(1, 5).toList();
22+
heroes = (await _heroService.getHeroes()).skip(1).take(4).toList();
2323
}
2424

2525
gotoDetail() {/* not implemented yet */}

public/docs/_examples/toh-5/dart/lib/hero.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ class Hero {
33
String name;
44

55
Hero(this.id, this.name);
6-
}
6+
}

public/docs/_examples/toh-5/dart/lib/hero_detail_component.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// #docplaster
2-
// #docregion
3-
// #docregion v2
2+
// #docregion , v2
43
import 'dart:async';
54
import 'dart:html';
65

public/docs/_examples/toh-5/dart/lib/heroes_component.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
margin: 0 0 2em 0;
77
list-style-type: none;
88
padding: 0;
9-
width: 10em;
9+
width: 15em;
1010
}
1111
.heroes li {
1212
cursor: pointer;

public/docs/_examples/toh-5/dart/lib/heroes_component.dart

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,9 @@ import 'hero_service.dart';
1414
selector: 'my-heroes',
1515
// #enddocregion heroes-component-renaming
1616
templateUrl: 'heroes_component.html',
17-
styleUrls: const ['heroes_component.css'],
18-
directives: const [HeroDetailComponent]
19-
// #docregion heroes-component-renaming
20-
)
17+
styleUrls: const ['heroes_component.css'],
18+
directives: const [HeroDetailComponent])
19+
// #docregion heroes-component-renaming
2120
// #enddocregion heroes-component-renaming, metadata
2221
// #docregion class, heroes-component-renaming
2322
class HeroesComponent implements OnInit {
@@ -37,9 +36,13 @@ class HeroesComponent implements OnInit {
3736
getHeroes();
3837
}
3938

40-
void onSelect(Hero hero) { selectedHero = hero; }
39+
void onSelect(Hero hero) {
40+
selectedHero = hero;
41+
}
4142

42-
Future<Null> gotoDetail() =>
43-
_router.navigate(['HeroDetail', {'id': selectedHero.id.toString()}]);
43+
Future<Null> gotoDetail() => _router.navigate([
44+
'HeroDetail',
45+
{'id': selectedHero.id.toString()}
46+
]);
4447
// #docregion heroes-component-renaming
4548
}

0 commit comments

Comments
 (0)