Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Commit e990594

Browse files
committed
convert 1-2-hybrid-bootstrap to upgrade/static
1 parent b0ca4f5 commit e990594

File tree

5 files changed

+24
-19
lines changed

5 files changed

+24
-19
lines changed

public/docs/_examples/protractor-helpers.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ export function waitForNg1AsyncBootstrap() {
3535
browser.driver.wait(function() {
3636
return element(by.css('.ng-scope')).isPresent();
3737
}, 5000);
38-
// Use this instead when upgrading to protractor > 4.0.10
39-
// browser.ng12Hybrid = true;
38+
}
39+
40+
export function setProtractorToHybridMode() {
41+
setProtractorToNg1Mode();
42+
browser.ng12Hybrid = true;
43+
// remove once waitForNg1AsyncBootstrap() is removed as well
44+
browser.ignoreSynchronization = false;
4045
}

public/docs/_examples/upgrade-adapter/e2e-spec.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict'; // necessary for es6 output in node
22

33
import { browser, element, by } from 'protractor';
4-
import { setProtractorToNg1Mode, waitForNg1AsyncBootstrap } from '../protractor-helpers';
4+
import { setProtractorToNg1Mode, waitForNg1AsyncBootstrap, setProtractorToHybridMode } from '../protractor-helpers';
55

66
describe('Upgrade Tests', function () {
77

@@ -35,9 +35,8 @@ describe('Upgrade Tests', function () {
3535
describe('NG1-2 Hybrid Bootstrap', function() {
3636

3737
beforeAll(function () {
38+
setProtractorToHybridMode();
3839
browser.get('/index-1-2-hybrid-bootstrap.html');
39-
setProtractorToNg1Mode();
40-
waitForNg1AsyncBootstrap();
4140
});
4241

4342
it('bootstraps as expected', function () {
Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,28 @@
11
declare var angular: any;
22
// #docregion ngmodule
33
import { NgModule } from '@angular/core';
4+
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
45
import { BrowserModule } from '@angular/platform-browser';
6+
import { UpgradeModule } from '@angular/upgrade/static';
57

68
@NgModule({
7-
imports: [ BrowserModule ]
9+
imports: [
10+
BrowserModule,
11+
UpgradeModule
12+
]
813
})
9-
export class AppModule {}
14+
export class AppModule {
15+
ngDoBootstrap() {}
16+
}
1017
// #enddocregion ngmodule
1118
angular.module('heroApp', [])
1219
.controller('MainCtrl', function() {
1320
this.message = 'Hello world';
1421
});
1522

16-
17-
// #docregion bootstrap
18-
import { UpgradeAdapter } from '@angular/upgrade';
19-
20-
// #enddocregion bootstrap
21-
22-
// This blank is expected to trigger the docplaster
23-
2423
// #docregion bootstrap
25-
26-
const upgradeAdapter = new UpgradeAdapter(AppModule);
27-
28-
upgradeAdapter.bootstrap(document.body, ['heroApp'], {strictDi: true});
24+
platformBrowserDynamic().bootstrapModule(AppModule).then(platformRef => {
25+
let upgrade = platformRef.injector.get(UpgradeModule);
26+
upgrade.bootstrap(document.body, ['heroApp'], {strictDi: true});
27+
});
2928
// #enddocregion bootstrap

public/docs/_examples/upgrade-adapter/ts/index-1-2-hybrid-bootstrap.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
<script src="node_modules/systemjs/dist/system.src.js"></script>
1717

1818
<script src="systemjs.config.js"></script>
19+
<script src="systemjs.config.extras.js"></script>
1920
<script>
2021
System.import('app/1-2-hybrid-bootstrap/app.module')
2122
.then(null, console.error.bind(console));

public/docs/_examples/upgrade-adapter/ts/index-upgrade-static.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
<script src="node_modules/systemjs/dist/system.src.js"></script>
1717

1818
<script src="systemjs.config.js"></script>
19+
<script src="systemjs.config.extras.js"></script>
1920
<script>
2021
System.import('app/upgrade-static/app.module')
2122
.then(null, console.error.bind(console));

0 commit comments

Comments
 (0)