chore: convert all e2e specs to typescript

Author: Foxandxss

public/docs/_examples/architecture/e2e-spec.ts

@@ -7,13 +7,13 @@ describe('Architecture', function () {
     browser.get('');
   });
 
-  function itReset(name: string, func: (v: void) => any) {
+  function itReset(name: string, func: () => any) {
     it(name, function() {
       browser.get('').then(func);
     });
   }
 
-  it('should display correct title: ' + title, function () {
+  it(`should display correct title: ${title}`, function () {
     expect(element(by.css('h2')).getText()).toEqual(title);
   });
 

public/docs/_examples/attribute-directives/e2e-spec.ts

@@ -7,7 +7,7 @@ describe('Attribute directives', function () {
     browser.get('');
   });
 
-  it('should display correct title: ' + _title, function () {
+  it(`should display correct title: ${_title}`, function () {
     expect(element(by.css('h1')).getText()).toEqual(_title);
   });
 

public/docs/_examples/hierarchical-dependency-injection/e2e-spec.ts

@@ -29,19 +29,18 @@ describe('Hierarchical dependency injection', function () {
     testEdit(false);
   });
 
-  function testEdit(shouldSave) {
-    let inputEle;
+  function testEdit(shouldSave: boolean) {
     // select 2nd ele
     let heroEle = element.all(by.css('heroes-list li')).get(1);
     // get the 2nd span which is the name of the hero
     let heroNameEle = heroEle.all(by.css('hero-card span')).get(1);
     let editButtonEle = heroEle.element(by.cssContainingText('button','edit'));
     editButtonEle.click().then(function() {
-      inputEle = heroEle.element(by.css('hero-editor input'));
+      let inputEle = heroEle.element(by.css('hero-editor input'));
       // return inputEle.sendKeys("foo");
       return sendKeys(inputEle, "foo");
     }).then(function() {
-      buttonName = shouldSave ? 'save' : 'cancel';
+      let buttonName = shouldSave ? 'save' : 'cancel';
       let buttonEle = heroEle.element(by.cssContainingText('button', buttonName));
       return buttonEle.click();
     }).then(function() {

public/docs/_examples/homepage-hello-world/e2e-spec.ts

@@ -7,18 +7,17 @@ describe('Homepage Hello World', function () {
 
   // Does it even launch?
   let expectedLabel = 'Name:';
-  it('should display the label: ' + expectedLabel, function () {
+  it(`should display the label: ${expectedLabel}`, function () {
     expect(element(by.css('label')).getText()).toEqual(expectedLabel);
   });
 
   it('should display entered name', function () {
     let testName = 'Bobby Joe';
-    let newValue;
     let nameEle = element.all(by.css('input')).get(0);
     nameEle.getAttribute('value').then(function(value) {
       // nameEle.sendKeys(testName); // should work but doesn't
       sendKeys(nameEle, testName); // utility that does work
-      newValue = value + testName; // old input box value + new name
+      let newValue = value + testName; // old input box value + new name
       expect(nameEle.getAttribute('value')).toEqual(newValue);
     }).then(function() {
       // Check the interpolated message built from name

public/docs/_examples/homepage-tabs/e2e-spec.ts

@@ -7,7 +7,7 @@ describe('Homepage Tabs', function () {
 
   // Does it even launch?
   let expectedAppTitle = 'Tabs Demo';
-  it('should display app title: ' + expectedAppTitle, function () {
+  it(`should display app title: ${expectedAppTitle}`, function () {
     expect(element(by.css('h4')).getText()).toEqual(expectedAppTitle);
   });
 

public/docs/_examples/homepage-todo/e2e-spec.ts

@@ -7,7 +7,7 @@ describe('Homepage Todo', function () {
 
   // Does it even launch?
   let expectedAppTitle = 'Todo';
-  it('should display app title: ' + expectedAppTitle, function () {
+  it(`should display app title: ${expectedAppTitle}`, function () {
     expect(element(by.css('h2')).getText()).toEqual(expectedAppTitle);
   });
 

public/docs/_examples/lifecycle-hooks/e2e-spec.ts

@@ -61,7 +61,7 @@ describe('Lifecycle hooks', function () {
     let powerInputEle = inputEles.get(0);
     let titleEle = doCheckViewEle.element(by.css('p'));
     let changeLogEles = doCheckViewEle.all(by.css('div'));
-    let logCount;
+    let logCount: number;
 
     expect(titleEle.getText()).toContain('Windstorm can sing');
     changeLogEles.count().then(function(count) {
@@ -92,7 +92,7 @@ describe('Lifecycle hooks', function () {
     let commentEle = parentEle.element(by.className('comment'));
     let logEles = parentEle.all(by.css('h4 ~ div'));
     let childViewInputEle = parentEle.element(by.css('my-child input'));
-    let logCount;
+    let logCount: number;
 
     expect(childViewInputEle.getAttribute('value')).toContain('Magneta');
     expect(commentEle.isPresent()).toBe(false, 'comment should not be in DOM');
@@ -121,7 +121,7 @@ describe('Lifecycle hooks', function () {
     let commentEle = parentEle.element(by.className('comment'));
     let logEles = parentEle.all(by.css('h4 ~ div'));
     let childViewInputEle = parentEle.element(by.css('my-child input'));
-    let logCount;
+    let logCount: number;
 
     expect(childViewInputEle.getAttribute('value')).toContain('Magneta');
     expect(commentEle.isPresent()).toBe(false, 'comment should not be in DOM');

public/docs/_examples/pipes/e2e-spec.ts

@@ -65,7 +65,7 @@ describe('Pipes', function () {
 
   it('should support flying heroes (pure) ', function () {
     let nameEle = element(by.css('flying-heroes input[type="text"]'));
-    let canFlyCheckEle = element(by.css('flying-heroes #can-fly'));    
+    let canFlyCheckEle = element(by.css('flying-heroes #can-fly'));
     let mutateCheckEle = element(by.css('flying-heroes #mutate'));
     let resetEle = element(by.css('flying-heroes button'));
     let flyingHeroesEle = element.all(by.css('flying-heroes #flyers div'));

public/docs/_examples/quickstart/e2e-spec.ts

@@ -3,12 +3,11 @@ describe('QuickStart E2E Tests', function () {
 
   let expectedMsg = 'My First Angular 2 App';
 
-
   beforeEach(function () {
     browser.get('');
   });
 
-  it('should display: ' + expectedMsg, function () {
+  it(`should display: ${expectedMsg}`, function () {
     expect(element(by.css('h1')).getText()).toEqual(expectedMsg);
   });
 

public/docs/_examples/router-deprecated/e2e-spec.js

@@ -6,7 +6,7 @@ describe('Router', function () {
   });
 
   function getPageStruct() {
-    hrefEles = element.all(by.css('my-app a'));
+    let hrefEles = element.all(by.css('my-app a'));
 
     return {
       hrefs: hrefEles,
@@ -66,7 +66,8 @@ describe('Router', function () {
 
   it('should be able to edit and save details from the heroes view', function () {
     let page = getPageStruct();
-    let heroEle, heroText;
+    let heroEle: protractor.ElementFinder;
+    let heroText: string;
     page.heroesHref.click().then(function() {
       heroEle = page.heroesList.get(4);
       return heroEle.getText();
@@ -90,9 +91,10 @@ describe('Router', function () {
     })
   });
 
-  function crisisCenterEdit(index, shouldSave) {
+  function crisisCenterEdit(index: number, shouldSave: boolean) {
     let page = getPageStruct();
-    let crisisEle, crisisText;
+    let crisisEle: protractor.ElementFinder;
+    let crisisText: string;
     page.crisisHref.click()
     .then(function () {
       crisisEle = page.crisisList.get(index);

public/docs/_examples/router-deprecated/e2e-spec.ts

@@ -6,7 +6,7 @@ describe('Router', function () {
   });
 
   function getPageStruct() {
-    hrefEles = element.all(by.css('my-app a'));
+    let hrefEles = element.all(by.css('my-app a'));
 
     return {
       hrefs: hrefEles,
@@ -66,7 +66,8 @@ describe('Router', function () {
 
   it('should be able to edit and save details from the heroes view', function () {
     let page = getPageStruct();
-    let heroEle, heroText;
+    let heroEle: protractor.ElementFinder;
+    let heroText: string;
     page.heroesHref.click().then(function() {
       heroEle = page.heroesList.get(4);
       return heroEle.getText();
@@ -90,9 +91,10 @@ describe('Router', function () {
     })
   });
 
-  function crisisCenterEdit(index, shouldSave) {
+  function crisisCenterEdit(index: number, shouldSave: boolean) {
     let page = getPageStruct();
-    let crisisEle, crisisText;
+    let crisisEle: protractor.ElementFinder;
+    let crisisText: string;
     page.crisisHref.click()
     .then(function () {
       crisisEle = page.crisisList.get(index);

public/docs/_examples/router/e2e-spec.ts

@@ -70,7 +70,7 @@ describe('Server Communication', function () {
       });
     });
 
-    function testForRefreshedResult(keyPressed, done) {
+    function testForRefreshedResult(keyPressed: string, done: () => void) {
       testForResult('my-wiki', keyPressed, false, done)
     }
   });
@@ -101,17 +101,17 @@ describe('Server Communication', function () {
     });
 
 
-    function testForNewResult(keyPressed, done) {
+    function testForNewResult(keyPressed: string, done: () => void) {
       testForResult('my-wiki-smart', keyPressed, false, done)
     }
 
-    function testForStaleResult(keyPressed, done) {
+    function testForStaleResult(keyPressed: string, done: () => void) {
       testForResult('my-wiki-smart', keyPressed, true, done)
     }
 
   });
 
-  function testForResult(componentTagName, keyPressed, hasListBeforeSearch, done) {
+  function testForResult(componentTagName: string, keyPressed: string, hasListBeforeSearch: boolean, done: () => void) {
     let searchWait = 1000; // Wait for wikipedia but not so long that tests timeout
     let wikiComponent = element(by.tagName(componentTagName));
     expect(wikiComponent).toBeDefined('<' + componentTagName + '> must exist');

public/docs/_examples/server-communication/e2e-spec.ts

@@ -32,7 +32,7 @@ describe('Structural Directives', function () {
     let ngIfSiblingEle = ngIfParentEle.element(by.css('heavy-loader'));
     let cssButtonEle = element(by.cssContainingText('button', 'show | hide'));
     let cssSiblingEle = cssButtonEle.element(by.xpath('..')).element(by.css('heavy-loader'));
-    let setConditionText;
+    let setConditionText: string;
     setConditionButtonEle.getText().then(function(text) {
       setConditionText = text;
       expect(ngIfButtonEle.isPresent()).toBe(true, 'should be able to find ngIfButton');

public/docs/_examples/structural-directives/e2e-spec.ts

@@ -6,7 +6,7 @@ describe('Getting Started E2E Tests', function() {
   let expectedMsg = 'My First Angular 2 App';
 
   // tests shared across languages
-  function sharedTests(basePath) {
+  function sharedTests(basePath: string) {
     beforeEach(function () {
       browser.get(basePath + 'index.html');
     });