Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Commit 52cd466

Browse files
committed
fix routing problem and aot setup
1 parent 6d5bacd commit 52cd466

File tree

8 files changed

+52
-65
lines changed

8 files changed

+52
-65
lines changed

public/docs/_examples/upgrade-phonecat-3-router/ts/aot/index.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@
3232
</head>
3333

3434
<body>
35-
<div class="view-container">
36-
<div ng-view class="view-frame"></div>
37-
</div>
35+
<phonecat-app></phonecat-app>
3836
</body>
3937
<script src="/dist/build.js"></script>
4038
</html>

public/docs/_examples/upgrade-phonecat-3-router/ts/app/app-routing.module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { APP_BASE_HREF, HashLocationStrategy, LocationStrategy } from '@angular/
66
import { PhoneDetailComponent } from './phone-detail/phone-detail.component';
77
import { PhoneListComponent } from './phone-list/phone-list.component';
88

9-
class Ng1Ng2UrlHandlingStrategy implements UrlHandlingStrategy {
9+
export class Ng1Ng2UrlHandlingStrategy implements UrlHandlingStrategy {
1010
// shouldProcessUrl(url: UrlTree) { return false; }
1111
shouldProcessUrl(url: UrlTree) {
1212
return url.toString().startsWith('/phones')
@@ -23,7 +23,7 @@ const routes: Routes = [
2323
];
2424

2525
@NgModule({
26-
imports: [ RouterModule.forRoot(routes, { initialNavigation: false }) ],
26+
imports: [ RouterModule.forRoot(routes) ],
2727
exports: [ RouterModule ],
2828
providers: [
2929
{ provide: APP_BASE_HREF, useValue: '!' },

public/docs/_examples/upgrade-phonecat-3-router/ts/app/app.module.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,9 @@ import { PhoneDetailComponent } from './phone-detail/phone-detail.component';
4040
],
4141
// #docregion bootstrap
4242
bootstrap: [ AppComponent ]
43-
// #enddocregion bootstrap
4443
})
45-
export class AppModule {
46-
ngDoBootstrap() {}
47-
}
44+
export class AppModule { }
45+
// #enddocregion bootstrap
4846

4947
export function routeParamsFactory(i: any) {
5048
return i.get('$routeParams');
Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
11
// #docregion
22
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
33
import { UpgradeModule } from '@angular/upgrade/static';
4-
import { Router } from '@angular/router';
54

65
import { AppModule } from './app.module';
76

87
platformBrowserDynamic().bootstrapModule(AppModule).then(platformRef => {
98
const upgrade = platformRef.injector.get(UpgradeModule) as UpgradeModule;
109
upgrade.bootstrap(document.documentElement, ['phonecatApp']);
11-
setTimeout(() => {
12-
platformRef.injector.get(Router).initialNavigation();
13-
}, 0);
1410
});

public/docs/_examples/upgrade-phonecat-3-router/ts/app/phone-detail/phone-detail.component.ng1.ts

Lines changed: 0 additions & 28 deletions
This file was deleted.

public/docs/_examples/upgrade-phonecat-3-router/ts/app/phone-list/phone-list.component.ng1.ts

Lines changed: 0 additions & 24 deletions
This file was deleted.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
// #docregion
2+
import rollup from 'rollup'
3+
import nodeResolve from 'rollup-plugin-node-resolve'
4+
import commonjs from 'rollup-plugin-commonjs';
5+
import uglify from 'rollup-plugin-uglify'
6+
7+
//paths are relative to the execution path
8+
export default {
9+
entry: 'app/main-aot.js',
10+
dest: 'aot/dist/build.js', // output a single application bundle
11+
sourceMap: true,
12+
sourceMapFile: 'aot/dist/build.js.map',
13+
format: 'iife',
14+
plugins: [
15+
nodeResolve({jsnext: true, module: true}),
16+
commonjs({
17+
include: ['node_modules/rxjs/**']
18+
}),
19+
uglify()
20+
]
21+
}
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
{
2+
"compilerOptions": {
3+
"target": "es5",
4+
"module": "es2015",
5+
"moduleResolution": "node",
6+
"sourceMap": true,
7+
"emitDecoratorMetadata": true,
8+
"experimentalDecorators": true,
9+
"removeComments": false,
10+
"noImplicitAny": true,
11+
"suppressImplicitAnyIndexErrors": true,
12+
"typeRoots": [
13+
"../../node_modules/@types/"
14+
]
15+
},
16+
17+
"files": [
18+
"app/app.module.ts",
19+
"app/main-aot.ts"
20+
],
21+
22+
"angularCompilerOptions": {
23+
"genDir": "aot",
24+
"skipMetadataEmit" : true
25+
}
26+
}

0 commit comments

Comments
 (0)