Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Commit 28d742f

Browse files
devversionNaomi Black
authored and
Naomi Black
committed
fix(about): dialog should not show twitter if empty
* The bio directive accidentally shows the Twitter link in the dialog, even if it's undefined. * Fix deprecation warning of Angular Material, where `md-dialog-actions` should be used instead of the class.
1 parent 0b95826 commit 28d742f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

public/about/index.jade

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
for person, name in bios
2323
if person.type == type
2424
.c3
25-
md-card(biocard class="bio-card" website="#{person.website}" twitter="#{person.twitter}" pic="#{person.picture}" bio="#{person.bio}" name="#{person.name}")
25+
md-card(biocard class="bio-card" website=person.website twitter=person.twitter pic=person.picture bio=person.bio name=person.name)
2626
header
2727
image(src="#{person.picture}" alt="#person.name")
2828

public/resources/js/directives/bio.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ angularIO.directive('biocard', function($rootScope, $timeout, $mdDialog) {
3333
' </div>' +
3434
' <p class="text-body">{{bio}}</p>' +
3535
' </md-content>' +
36-
' <div class="md-actions">' +
36+
' <md-dialog-actions>' +
3737
' <md-button ng-click="closeDialog()">' +
3838
' Close Bio' +
3939
' </md-button>' +
40-
' </div>' +
40+
' </md-dialog-actions>' +
4141
'</md-dialog>'
4242
});
4343
});

0 commit comments

Comments
 (0)