Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Commit 2026e50

Browse files
chalinwardbell
authored andcommitted
docs: fix remaining broken links (#2832)
* docs: fix remaining broken links In particular, don’t show the language dropdown for the docs change-log page (since JS and Dart don’t have a change log). Together with #2830, this fixes #2150 * ignore invalid link from about bios
1 parent b3c65a9 commit 2026e50

File tree

3 files changed

+16
-14
lines changed

3 files changed

+16
-14
lines changed

gulpfile.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,9 @@ gulp.task('link-checker', function(done) {
793793
'resources/%7B%7Bresource.url%7D%7D',
794794
// API docs have links directly into GitHub repo sources; these can
795795
// quickly become invalid, so ignore them for now:
796-
'*/angular/tree/*'
796+
'*/angular/tree/*',
797+
// harp.json "bios" for "Ryan Schmukler", URL isn't valid:
798+
'http://slingingcode.com'
797799
];
798800
var blcOptions = { requestMethod: method, excludedKeywords: exclude};
799801
return linkChecker({ blcOptions: blcOptions });

public/_includes/_version-dropdown.jade

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,16 @@ if language == 'dart'
6161
else
6262
- var title = 'Angular ' + version + ' for Dart'
6363

64+
if current.path[4] !== 'change-log'
65+
//- DROPDOWN BUTTON
66+
nav.dropdown
67+
button(aria-label="Select a version of Angular" md-button class="dropdown-button" ng-click="appCtrl.toggleVersionMenu($event)") #{title} <span class="icon icon-arrow-drop-down"></span>
68+
div(class="overlay ng-hide" ng-click="appCtrl.toggleVersionMenu($event)" ng-show="appCtrl.showMenu")
6469

65-
<!-- DROPDOWN BUTTON -->
66-
nav.dropdown
67-
button(aria-label="Select a version of Angular" md-button class="dropdown-button" ng-click="appCtrl.toggleVersionMenu($event)") #{title} <span class="icon icon-arrow-drop-down"></span>
68-
div(class="overlay ng-hide" ng-click="appCtrl.toggleVersionMenu($event)" ng-show="appCtrl.showMenu")
69-
70-
<!-- DROPDOWN MENU -->
71-
ul(class="dropdown-menu" ng-class="appCtrl.showMenu ? 'is-visible' : ''")
72-
mixin tree(public.docs.ts, "/docs/ts", "Angular for TypeScript")
73-
mixin tree(public.docs.js, "/docs/js", "Angular for JavaScript")
74-
//- Disable cross-language link for API entry pages (but keep for top API search page):
75-
if ! (current.path[3] === 'api' && public.docs[current.path[1]][current.path[2]][current.path[3]][current.path[4]])
76-
mixin tree(public.docs.dart, "/docs/dart", "Angular for Dart")
70+
//- DROPDOWN MENU
71+
ul(class="dropdown-menu" ng-class="appCtrl.showMenu ? 'is-visible' : ''")
72+
mixin tree(public.docs.ts, "/docs/ts", "Angular for TypeScript")
73+
mixin tree(public.docs.js, "/docs/js", "Angular for JavaScript")
74+
//- Disable cross-language link for API entry pages (but keep for top API search page):
75+
if ! (current.path[3] === 'api' && public.docs[current.path[1]][current.path[2]][current.path[3]][current.path[4]])
76+
mixin tree(public.docs.dart, "/docs/dart", "Angular for Dart")

public/docs/js/latest/quickstart.jade

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ code-example(format="").
282282

283283
Create a `styles.css` file in the *#{_indexHtmlDir}* folder and start styling, perhaps with the minimal
284284
styles shown below. For the full set of master styles used by the documentation samples,
285-
see [styles.css](https://github.com/angular/angular.io/blob/master/public/docs/_examples/styles.css).
285+
see [styles.css](https://github.com/angular/angular.io/blob/master/public/docs/_examples/_boilerplate/styles.css).
286286
+makeExample('quickstart/js/styles.1.css', null, 'styles.css')(format=".")
287287

288288
.l-main-section

0 commit comments

Comments
 (0)