fix(@angular-devkit/build-angular): several fixes to assets and files writes in browser-esbuild builder #26022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
fixes-file-writes
branch
from
a8f701a to
9c6907f
Compare
alan-agius4
added
action: review
alan-agius4
force-pushed
the
fixes-file-writes
branch
from
9c6907f to
e8faaac
Compare
zip-fa
reviewed
Oct 12, 2023
| } | ||
| } | ||
|
|
||
| const MAX_CONCURRENT_WRITES = 64; |
There was a problem hiding this comment.
Maybe give option to increase this value with --max-concurrent-writes=100 for example?
There was a problem hiding this comment.
Adding an option is not something that we plan to do. Instead we opted for a sensible default.
alan-agius4
force-pushed
the
fixes-file-writes
branch
from
e8faaac to
fdcec79
Compare
alan-agius4
removed
the
action: review
alan-agius4
force-pushed
the
fixes-file-writes
branch
from
fdcec79 to
61afb1f
Compare
alan-agius4
force-pushed
the
fixes-file-writes
branch
2 times, most recently
from
ae67402 to
750a67b
Compare
alan-agius4
force-pushed
the
fixes-file-writes
branch
from
750a67b to
55422d5
Compare
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
fixes-file-writes
branch
from
d1a5e5f to
d454353
Compare
clydin
approved these changes
Oct 12, 2023
… writes in browser-esbuild builder This commit ports angular#26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory. Closes angular#26021
alan-agius4
force-pushed
the
fixes-file-writes
branch
from
d454353 to
3397778
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ports #26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.
Closes #26021