From 4eda68b94ad00c59a69d5f99c9bd263d0810f75a Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Fri, 26 Oct 2018 13:36:56 +0200 Subject: [PATCH 1/2] fix(@angular-devkit/core): errors and warnings are hard to read in windows cmd Closes #12755 --- packages/angular_devkit/core/node/cli-logger.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/angular_devkit/core/node/cli-logger.ts b/packages/angular_devkit/core/node/cli-logger.ts index 0cbbd4c1059e..6acadceb6ae4 100644 --- a/packages/angular_devkit/core/node/cli-logger.ts +++ b/packages/angular_devkit/core/node/cli-logger.ts @@ -32,13 +32,10 @@ export function createConsoleLogger( color = terminal.white; break; case 'warn': - color = terminal.yellow; - break; - case 'error': - color = terminal.red; - output = stderr; + color = (x: string) => terminal.bold(terminal.yellow(x)); break; case 'fatal': + case 'error': color = (x: string) => terminal.bold(terminal.red(x)); output = stderr; break; From e5f5ec73704a53d132364381a6ab0b94c598b588 Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Fri, 26 Oct 2018 13:37:03 +0200 Subject: [PATCH 2/2] fix(@angular/cli): errors and warnings are hard to read in windows cmd Closes #12755 --- packages/angular/cli/lib/cli/index.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/angular/cli/lib/cli/index.ts b/packages/angular/cli/lib/cli/index.ts index 968d184e3c32..19b61c7036fd 100644 --- a/packages/angular/cli/lib/cli/index.ts +++ b/packages/angular/cli/lib/cli/index.ts @@ -81,19 +81,17 @@ function initializeLogging(logger: logging.Logger) { color = terminal.white; break; case 'warn': - color = terminal.yellow; - output = process.stderr; - break; - case 'error': - color = terminal.red; + color = (x: string) => terminal.bold(terminal.yellow(x)); output = process.stderr; break; case 'fatal': - color = (x) => terminal.bold(terminal.red(x)); + case 'error': + color = (x: string) => terminal.bold(terminal.red(x)); output = process.stderr; break; } + // If we do console.log(message) or process.stdout.write(message + '\n'), the process might // stop before the whole message is written and the stream is flushed. This happens when // streams are asynchronous.