Skip to content

Commit eced3a8

Browse files
clydinalan-agius4
authored andcommitted
test: enable no-fallthrough lint rule
The `no-fallthrough` rule is now enabled and all failures have been addressed within the code.
1 parent 1271e4a commit eced3a8

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

.eslintrc.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@
101101

102102
/* TODO: evaluate usage of these rules and fix issues as needed */
103103
"no-case-declarations": "off",
104-
"no-fallthrough": "off",
105104
"no-underscore-dangle": "off",
106105
"@typescript-eslint/ban-types": "off",
107106
"@typescript-eslint/no-implied-eval": "off",

packages/angular/build/src/builders/extract-i18n/options.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ export async function normalizeOptions(
4242
// Normalize xliff format extensions
4343
let format = options.format;
4444
switch (format) {
45-
case undefined:
4645
// Default format is xliff1
46+
case undefined:
4747
case Format.Xlf:
4848
case Format.Xlif:
4949
case Format.Xliff:

packages/angular_devkit/build_angular/src/builders/extract-i18n/options.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ export async function normalizeOptions(
4242
// Normalize xliff format extensions
4343
let format = options.format;
4444
switch (format) {
45-
case undefined:
4645
// Default format is xliff1
46+
case undefined:
4747
case Format.Xlf:
4848
case Format.Xlif:
4949
case Format.Xliff:

packages/angular_devkit/build_angular/src/tools/babel/webpack-loader.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,7 @@ export default custom<ApplicationPresetOptions>(() => {
200200
case 'error':
201201
this.emitError(message);
202202
break;
203-
case 'info':
204-
// Webpack does not currently have an informational diagnostic
203+
case 'info': // Webpack does not currently have an informational diagnostic
205204
case 'warning':
206205
this.emitWarning(message);
207206
break;

0 commit comments

Comments
 (0)