Skip to content

Commit e75aa9b

Browse files
clydinalan-agius4
authored andcommitted
fix(@angular-devkit/build-angular): downgrade copy-webpack-plugin to workaround Node.js support issue
The `copy-webpack-plugin@12` package has a dependency on the `globby@14` package. The recently released `globby@14.0.1` uses the `merge-streams@2.1.0` package which requires a minimum Node.js version higher than the officially supported 18.13 for the Angular CLI. Due to both `globby` and `merge-streams` being transitive dependencies in end-user projects, the Angular CLI cannot directly control the package versions. However, `copy-webpack-plugin@11` uses `globby@13` which is not affected by the Node.js version problem. To workaround the Node.js compatibility problem, `copy-webpack-plugin` has been downgraded to version 11.0.0 which is the latest version in the 11 major for the package. The `copy-webpack-plugin` is only used with the Webpack-based builders when in watch mode. From a review of the commit history between 11.0.0 and 12.0.2 (latest at the time of this commit), it appears the only notable changes are several performance improvements and the major version update of `globby`.
1 parent d7dccbf commit e75aa9b

File tree

3 files changed

+39
-9
lines changed

3 files changed

+39
-9
lines changed

packages/angular_devkit/build_angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"babel-loader": "9.1.3",
2828
"babel-plugin-istanbul": "6.1.1",
2929
"browserslist": "^4.21.5",
30-
"copy-webpack-plugin": "12.0.2",
30+
"copy-webpack-plugin": "11.0.0",
3131
"critters": "0.0.20",
3232
"css-loader": "6.10.0",
3333
"esbuild-wasm": "0.20.0",

renovate.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,13 @@
1212
"dependencyDashboard": true,
1313
"schedule": ["after 10:00pm every weekday", "before 4:00am every weekday", "every weekend"],
1414
"baseBranches": ["main"],
15-
"ignoreDeps": ["@types/node", "aspect_bazel_lib", "rules_pkg", "less-loader"],
15+
"ignoreDeps": [
16+
"@types/node",
17+
"aspect_bazel_lib",
18+
"rules_pkg",
19+
"less-loader",
20+
"copy-webpack-plugin"
21+
],
1622
"includePaths": [
1723
"WORKSPACE",
1824
"package.json",

yarn.lock

Lines changed: 31 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,7 @@
131131
tslib "^2.3.0"
132132

133133
"@angular/bazel@https://github.com/angular/bazel-builds.git#55bd95c99e8fed8fbb2c2a5c052f6b25d0da849f":
134-
version "17.3.0-next.0+sha-abf6371"
135-
uid "55bd95c99e8fed8fbb2c2a5c052f6b25d0da849f"
134+
version "17.3.0-next.0"
136135
resolved "https://github.com/angular/bazel-builds.git#55bd95c99e8fed8fbb2c2a5c052f6b25d0da849f"
137136
dependencies:
138137
"@microsoft/api-extractor" "^7.24.2"
@@ -149,7 +148,6 @@
149148

150149
"@angular/build-tooling@https://github.com/angular/dev-infra-private-build-tooling-builds.git#7c4cf003cb4ac849986beaa243d7e85a893612f2":
151150
version "0.0.0-c83e99a12397014162531ca125c94549db55dd84"
152-
uid "7c4cf003cb4ac849986beaa243d7e85a893612f2"
153151
resolved "https://github.com/angular/dev-infra-private-build-tooling-builds.git#7c4cf003cb4ac849986beaa243d7e85a893612f2"
154152
dependencies:
155153
"@angular-devkit/build-angular" "17.2.0-next.0"
@@ -317,7 +315,6 @@
317315

318316
"@angular/ng-dev@https://github.com/angular/dev-infra-private-ng-dev-builds.git#c21f93acb618bcaeda52a8065e7b6c9242def182":
319317
version "0.0.0-c83e99a12397014162531ca125c94549db55dd84"
320-
uid c21f93acb618bcaeda52a8065e7b6c9242def182
321318
resolved "https://github.com/angular/dev-infra-private-ng-dev-builds.git#c21f93acb618bcaeda52a8065e7b6c9242def182"
322319
dependencies:
323320
"@yarnpkg/lockfile" "^1.1.0"
@@ -6030,6 +6027,18 @@ copy-anything@^2.0.1:
60306027
dependencies:
60316028
is-what "^3.14.1"
60326029

6030+
copy-webpack-plugin@11.0.0:
6031+
version "11.0.0"
6032+
resolved "https://registry.yarnpkg.com/copy-webpack-plugin/-/copy-webpack-plugin-11.0.0.tgz#96d4dbdb5f73d02dd72d0528d1958721ab72e04a"
6033+
integrity sha512-fX2MWpamkW0hZxMEg0+mYnA40LTosOSa5TqZ9GYIBzyJa9C3QUaMPSE2xAi/buNr8u89SfD9wHSQVBzrRa/SOQ==
6034+
dependencies:
6035+
fast-glob "^3.2.11"
6036+
glob-parent "^6.0.1"
6037+
globby "^13.1.1"
6038+
normalize-path "^3.0.0"
6039+
schema-utils "^4.0.0"
6040+
serialize-javascript "^6.0.0"
6041+
60336042
copy-webpack-plugin@12.0.2:
60346043
version "12.0.2"
60356044
resolved "https://registry.yarnpkg.com/copy-webpack-plugin/-/copy-webpack-plugin-12.0.2.tgz#935e57b8e6183c82f95bd937df658a59f6a2da28"
@@ -7138,7 +7147,7 @@ fast-fifo@^1.1.0, fast-fifo@^1.2.0:
71387147
resolved "https://registry.yarnpkg.com/fast-fifo/-/fast-fifo-1.3.2.tgz#286e31de96eb96d38a97899815740ba2a4f3640c"
71397148
integrity sha512-/d9sfos4yxzpwkDkuN7k2SqFKtYNmCTzgfEpz82x34IM9/zc8KGxQoXg1liNC/izpRM/MBdt44Nmx41ZWqk+FQ==
71407149

7141-
fast-glob@3.3.2, fast-glob@^3.2.9, fast-glob@^3.3.1, fast-glob@^3.3.2:
7150+
fast-glob@3.3.2, fast-glob@^3.2.11, fast-glob@^3.2.9, fast-glob@^3.3.0, fast-glob@^3.3.1, fast-glob@^3.3.2:
71427151
version "3.3.2"
71437152
resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.3.2.tgz#a904501e57cfdd2ffcded45e99a54fef55e46129"
71447153
integrity sha512-oX2ruAFQwf/Orj8m737Y5adxDQO0LAB7/S5MnxCdTNDd4p6BsyIVsv9JQsATbTSq8KHRpLwIHbVlUNatxd+1Ow==
@@ -7675,6 +7684,17 @@ globby@^11.0.1, globby@^11.1.0:
76757684
merge2 "^1.4.1"
76767685
slash "^3.0.0"
76777686

7687+
globby@^13.1.1:
7688+
version "13.2.2"
7689+
resolved "https://registry.yarnpkg.com/globby/-/globby-13.2.2.tgz#63b90b1bf68619c2135475cbd4e71e66aa090592"
7690+
integrity sha512-Y1zNGV+pzQdh7H39l9zgB4PJqjRNqydvdYCDG4HFXM4XuvSaQQlEc91IU1yALL8gUTDomgBAfz3XJdmUS+oo0w==
7691+
dependencies:
7692+
dir-glob "^3.0.1"
7693+
fast-glob "^3.3.0"
7694+
ignore "^5.2.4"
7695+
merge2 "^1.4.1"
7696+
slash "^4.0.0"
7697+
76787698
globby@^14.0.0:
76797699
version "14.0.1"
76807700
resolved "https://registry.yarnpkg.com/globby/-/globby-14.0.1.tgz#a1b44841aa7f4c6d8af2bc39951109d77301959b"
@@ -11900,7 +11920,6 @@ sass@1.70.0, sass@^1.69.5:
1190011920

1190111921
"sauce-connect-proxy@https://saucelabs.com/downloads/sc-4.9.1-linux.tar.gz":
1190211922
version "0.0.0"
11903-
uid "9310bc860f7870a1f872b11c4dc6073a1ad34e5e"
1190411923
resolved "https://saucelabs.com/downloads/sc-4.9.1-linux.tar.gz#9310bc860f7870a1f872b11c4dc6073a1ad34e5e"
1190511924

1190611925
saucelabs@^1.5.0:
@@ -12033,7 +12052,7 @@ send@0.18.0, send@^0.18.0:
1203312052
range-parser "~1.2.1"
1203412053
statuses "2.0.1"
1203512054

12036-
serialize-javascript@^6.0.1, serialize-javascript@^6.0.2:
12055+
serialize-javascript@^6.0.0, serialize-javascript@^6.0.1, serialize-javascript@^6.0.2:
1203712056
version "6.0.2"
1203812057
resolved "https://registry.yarnpkg.com/serialize-javascript/-/serialize-javascript-6.0.2.tgz#defa1e055c83bf6d59ea805d8da862254eb6a6c2"
1203912058
integrity sha512-Saa1xPByTTq2gdeFZYLLo+RFE35NHZkAbqZeWNd3BpzppeVisAqpDjcp8dyf6uIvEqJRd46jemmyA4iFIeVk8g==
@@ -12194,6 +12213,11 @@ slash@^3.0.0:
1219412213
resolved "https://registry.yarnpkg.com/slash/-/slash-3.0.0.tgz#6539be870c165adbd5240220dbe361f1bc4d4634"
1219512214
integrity sha512-g9Q1haeby36OSStwb4ntCGGGaKsaVSjQ68fBxoQcutl5fS1vuY18H3wSt3jFyFtrkx+Kz0V1G85A4MyAdDMi2Q==
1219612215

12216+
slash@^4.0.0:
12217+
version "4.0.0"
12218+
resolved "https://registry.yarnpkg.com/slash/-/slash-4.0.0.tgz#2422372176c4c6c5addb5e2ada885af984b396a7"
12219+
integrity sha512-3dOsAHXXUkQTpOYcoAxLIorMTp4gIQr5IW3iVb7A7lFIp0VHhnynm9izx6TssdrIcVIESAlVjtnO2K8bg+Coew==
12220+
1219712221
slash@^5.1.0:
1219812222
version "5.1.0"
1219912223
resolved "https://registry.yarnpkg.com/slash/-/slash-5.1.0.tgz#be3adddcdf09ac38eebe8dcdc7b1a57a75b095ce"

0 commit comments

Comments
 (0)