Skip to content

Commit d8ba2fe

Browse files
clydinangular-robot[bot]
authored andcommitted
test(@angular-devkit/build-angular): enable additional styles tests for esbuild builder
Now that output stat logging for the esbuild-based browser application builder has been implemented, the previously disabled styles option tests can be enabled.
1 parent 00d58fe commit d8ba2fe

File tree

1 file changed

+3
-6
lines changed
  • packages/angular_devkit/build_angular/src/builders/browser-esbuild/tests/options

1 file changed

+3
-6
lines changed

packages/angular_devkit/build_angular/src/builders/browser-esbuild/tests/options/styles_spec.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => {
129129
harness.expectFile('dist/styles.css').toNotExist();
130130
});
131131

132-
// TODO: Re-enable once output logging is implemented for esbuild builder
133-
xit('shows the output style as a chunk entry in the logging output', async () => {
132+
it('shows the output style as a chunk entry in the logging output', async () => {
134133
await harness.writeFile('src/test-style-a.css', '.test-a {color: red}');
135134

136135
harness.useTarget('build', {
@@ -401,8 +400,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => {
401400
.content.not.toContain('<link rel="stylesheet" href="extra.css">');
402401
});
403402

404-
// TODO: Re-enable once output logging is implemented for esbuild builder
405-
xit('shows the output style as a chunk entry in the logging output', async () => {
403+
it('shows the output style as a chunk entry in the logging output', async () => {
406404
await harness.writeFile('src/test-style-a.css', '.test-a {color: red}');
407405

408406
harness.useTarget('build', {
@@ -419,8 +417,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => {
419417
);
420418
});
421419

422-
// TODO: Re-enable once output logging is implemented for esbuild builder
423-
xit('shows the output style as a chunk entry with bundleName in the logging output', async () => {
420+
it('shows the output style as a chunk entry with bundleName in the logging output', async () => {
424421
await harness.writeFile('src/test-style-a.css', '.test-a {color: red}');
425422

426423
harness.useTarget('build', {

0 commit comments

Comments
 (0)