Skip to content

Commit c97852e

Browse files
filipesilvahansl
authored andcommitted
test: remove build optimizer integration test
Testing the size of a simple app is now done directly in the large specs inside devkit/build-angular. The Angular.io test was very out of date, and Angular.io now keeps track of its bundle size much better than we ever did.
1 parent 54047d7 commit c97852e

File tree

101 files changed

+0
-15798
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

101 files changed

+0
-15798
lines changed

.circleci/config.yml

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -65,29 +65,6 @@ jobs:
6565
- restore_cache: *_root_package_lock_key
6666
- run: xvfb-run -a npm run test-cli-e2e -- --nb-shards=${CIRCLE_NODE_TOTAL} --shard=${CIRCLE_NODE_INDEX}
6767

68-
integration:
69-
<<: *defaults
70-
steps:
71-
- checkout:
72-
<<: *post_checkout
73-
- restore_cache:
74-
key: angular_devkit-{{ checksum "package-lock.json" }}
75-
- restore_cache:
76-
key: angular_devkit-integration-simple-{{ checksum "tests/@angular_devkit/build_optimizer/webpack/simple-app/package-lock.json" }}
77-
- restore_cache:
78-
key: angular_devkit-integration-aio-{{ checksum "tests/@angular_devkit/build_optimizer/webpack/aio-app/package-lock.json" }}
79-
80-
- run: xvfb-run -a npm run integration
81-
82-
- save_cache:
83-
key: angular_devkit-integration-simple-{{ checksum "tests/@angular_devkit/build_optimizer/webpack/simple-app/package-lock.json" }}
84-
paths:
85-
- "tests/@angular_devkit/build_optimizer/webpack/simple-app/node_modules"
86-
- save_cache:
87-
key: angular_devkit-integration-aio-{{ checksum "tests/@angular_devkit/build_optimizer/webpack/aio-app/package-lock.json" }}
88-
paths:
89-
- "tests/@angular_devkit/build_optimizer/webpack/aio-app/node_modules"
90-
9168
build:
9269
<<: *defaults
9370
steps:
@@ -157,9 +134,6 @@ workflows:
157134
- test-large:
158135
requires:
159136
- build
160-
- integration:
161-
requires:
162-
- build
163137
- e2e-cli:
164138
requires:
165139
- build
@@ -175,7 +149,6 @@ workflows:
175149
requires:
176150
- test
177151
- build
178-
- integration
179152
- snapshot_publish
180153
filters:
181154
tags:

package.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@
3232
"test:watch": "nodemon --watch packages -e ts ./bin/devkit-admin test",
3333
"validate": "node ./bin/devkit-admin validate",
3434
"validate-commits": "./bin/devkit-admin validate-commits",
35-
"integration": "npm run build && npm run integration:build-optimizer",
36-
"integration:build-optimizer": "npm run integration:build-optimizer:simple && npm run integration:build-optimizer:aio",
37-
"integration:build-optimizer:simple": "cd tests/@angular_devkit/build_optimizer/webpack/simple-app && npm i -q --no-save && npm run e2e && npm run benchmark",
38-
"integration:build-optimizer:aio": "cd tests/@angular_devkit/build_optimizer/webpack/aio-app && npm i -q --no-save && npm run e2e && npm run benchmark",
3935
"prepush": "node ./bin/devkit-admin hooks/pre-push",
4036
"webdriver-update-appveyor": "webdriver-manager update --standalone false --gecko false --versions.chrome 2.37",
4137
"webdriver-update-circleci": "webdriver-manager update --standalone false --gecko false --versions.chrome 2.33"

tests/@angular_devkit/build_optimizer/webpack/aio-app/.gitignore

Lines changed: 0 additions & 4 deletions
This file was deleted.

tests/@angular_devkit/build_optimizer/webpack/aio-app/benchmark.js

Lines changed: 0 additions & 77 deletions
This file was deleted.

tests/@angular_devkit/build_optimizer/webpack/aio-app/bs-config.json

Lines changed: 0 additions & 11 deletions
This file was deleted.

tests/@angular_devkit/build_optimizer/webpack/aio-app/e2e/app.e2e-spec.ts

Lines changed: 0 additions & 24 deletions
This file was deleted.

tests/@angular_devkit/build_optimizer/webpack/aio-app/e2e/tsconfig.json

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)