build: update to @types/node version 12

Author: alan-agius4

package.json

@@ -109,7 +109,7 @@
     "@types/loader-utils": "^2.0.0",
     "@types/minimatch": "3.0.3",
     "@types/minimist": "^1.2.0",
-    "@types/node": "10.12.30",
+    "@types/node": "~12.12.6",
     "@types/node-fetch": "^2.1.6",
     "@types/npm-package-arg": "^6.1.0",
     "@types/parse5-html-rewriting-stream": "^5.1.2",

packages/angular/cli/lib/init.ts

@@ -135,18 +135,9 @@ if (process.env['NG_CLI_PROFILING']) {
 
   return cli;
 })().then(cli => {
-  // This is required to support 1.x local versions with a 6+ global
-  let standardInput;
-  try {
-    standardInput = process.stdin;
-  } catch (e) {
-    process.stdin = new Duplex();
-    standardInput = process.stdin;
-  }
-
   return cli({
     cliArgs: process.argv.slice(2),
-    inputStream: standardInput,
+    inputStream: process.stdin,
     outputStream: process.stdout,
   });
 }).then((exitCode: number) => {

packages/angular/cli/utilities/color.ts

@@ -9,11 +9,7 @@ import * as ansiColors from 'ansi-colors';
 import { WriteStream } from 'tty';
 
 type AnsiColors = typeof ansiColors;
-
-// Typings do not contain the function call (added in Node.js v9.9.0)
-const supportsColor =
-  process.stdout instanceof WriteStream &&
-  ((process.stdout as unknown) as { getColorDepth(): number }).getColorDepth() > 1;
+const supportsColor = process.stdout instanceof WriteStream && process.stdout.getColorDepth() > 1;
 
 export function removeColor(text: string): string {
   // This has been created because when colors.enabled is false unstyle doesn't work

packages/angular/pwa/pwa/index.ts

@@ -63,7 +63,7 @@ function updateIndexFile(path: string): Rule {
 
       const chunks: Array<Buffer> = [];
       const output = new Writable({
-        write(chunk: string | Buffer, encoding: string, callback: Function): void {
+        write(chunk: string | Buffer, encoding: BufferEncoding, callback: Function): void {
           chunks.push(typeof chunk === 'string' ? Buffer.from(chunk, encoding) : chunk);
           callback();
         },

packages/angular_devkit/architect/node/node-modules-architect-host.ts

@@ -7,7 +7,7 @@
  */
 import { json, workspaces } from '@angular-devkit/core';
 import * as path from 'path';
-import * as v8 from 'v8';
+import { deserialize, serialize } from 'v8';
 import { BuilderInfo } from '../src';
 import { Schema as BuilderSchema } from '../src/builders-schema';
 import { Target } from '../src/input-schema';
@@ -18,9 +18,6 @@ export type NodeModulesBuilderInfo = BuilderInfo & {
 };
 
 function clone(obj: unknown): unknown {
-  const serialize = ((v8 as unknown) as { serialize(value: unknown): Buffer }).serialize;
-  const deserialize = ((v8 as unknown) as { deserialize(buffer: Buffer): unknown }).deserialize;
-
   try {
     return deserialize(serialize(obj));
   } catch {

packages/angular_devkit/benchmark/src/monitored-process.ts

@@ -51,8 +51,8 @@ export class LocalMonitoredProcess implements MonitoredProcess {
       const childProcess = spawn(cmd, args, spawnOptions);
 
       // Emit output and stats.
-      childProcess.stdout.on('data', (data: Buffer) => this.stdout.next(data));
-      childProcess.stderr.on('data', (data: Buffer) => this.stderr.next(data));
+      childProcess.stdout?.on('data', (data: Buffer) => this.stdout.next(data));
+      childProcess.stderr?.on('data', (data: Buffer) => this.stderr.next(data));
 
       const statsSubs = timer(0, this.pollingRate).pipe(
         concatMap(() => from(pidtree(childProcess.pid, { root: true }) as Promise<number[]>)),

packages/angular_devkit/build_angular/src/utils/color.ts

@@ -9,11 +9,7 @@ import * as ansiColors from 'ansi-colors';
 import { WriteStream } from 'tty';
 
 type AnsiColors = typeof ansiColors;
-
-// Typings do not contain the function call (added in Node.js v9.9.0)
-const supportsColor =
-  process.stdout instanceof WriteStream &&
-  ((process.stdout as unknown) as { getColorDepth(): number }).getColorDepth() > 1;
+const supportsColor = process.stdout instanceof WriteStream && process.stdout.getColorDepth() > 1;
 
 export function removeColor(text: string): string {
   // This has been created because when colors.enabled is false unstyle doesn't work

packages/angular_devkit/build_angular/src/utils/index-file/html-rewriting-stream.ts

@@ -28,7 +28,7 @@ export async function htmlRewritingStream(content: string): Promise<{
       .pipe(rewriter)
       .pipe(new Writable({
         write(chunk: string | Buffer, encoding: string | undefined, callback: Function): void {
-          chunks.push(typeof chunk === 'string' ? Buffer.from(chunk, encoding) : chunk);
+          chunks.push(typeof chunk === 'string' ? Buffer.from(chunk, encoding as BufferEncoding) : chunk);
           callback();
         },
         final(callback: (error?: Error) => void): void {

packages/angular_devkit/build_angular/src/webpack/configs/dev-server.ts

@@ -55,7 +55,7 @@ export function getDevServerConfig(
     }
 
     const parsedHost = url.parse(publicHost);
-    publicHost = parsedHost.host;
+    publicHost = parsedHost.host ?? undefined;
   } else {
     publicHost = '0.0.0.0:0';
   }

packages/angular_devkit/build_webpack/src/webpack-dev-server/index.ts

@@ -93,6 +93,12 @@ export function runWebpackDevServer(
             obs.error(err);
           } else {
             const address = this.address();
+            if (!address) {
+              obs.error(new Error(`Dev-server address info is not defined.`));
+
+              return;
+            }
+
             result = {
               success: true,
               port: typeof address === 'string' ? 0 : address.port,

packages/angular_devkit/core/node/host.ts

@@ -58,10 +58,10 @@ function loadFSWatcher() {
   }
 }
 
-type FsFunction0<R> = (cb: (err?: Error, result?: R) => void) => void;
-type FsFunction1<R, T1> = (p1: T1, cb: (err?: Error, result?: R) => void) => void;
+type FsFunction0<R> = (cb: (err?: Error|null, result?: R) => void) => void;
+type FsFunction1<R, T1> = (p1: T1, cb: (err?: Error|null, result?: R) => void) => void;
 type FsFunction2<R, T1, T2>
-  = (p1: T1, p2: T2, cb: (err?: Error, result?: R) => void) => void;
+  = (p1: T1, p2: T2, cb: (err?: Error|null, result?: R) => void) => void;
 
 
 function _callFs<R>(fn: FsFunction0<R>): Observable<R>;
@@ -70,7 +70,7 @@ function _callFs<R, T1, T2>(fn: FsFunction2<R, T1, T2>, p1: T1, p2: T2): Observa
 
 function _callFs<ResultT>(fn: Function, ...args: {}[]): Observable<ResultT> {
   return new Observable(obs => {
-    fn(...args, (err?: Error, result?: ResultT) => {
+    fn(...args, (err?: Error|null, result?: ResultT) => {
       if (err) {
         obs.error(err);
       } else {

packages/angular_devkit/schematics/tasks/package-manager/executor.ts

@@ -125,9 +125,9 @@ export default function(
           }
       });
       if (options.hideOutput) {
-        childProcess.stdout.on('data', (data: Buffer) =>
+        childProcess.stdout?.on('data', (data: Buffer) =>
           bufferedOutput.push({ stream: process.stdout, data: data }));
-        childProcess.stderr.on('data', (data: Buffer) =>
+        childProcess.stderr?.on('data', (data: Buffer) =>
           bufferedOutput.push({ stream: process.stderr, data: data }));
       }
     });

yarn.lock

@@ -1663,16 +1663,16 @@
   resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.25.tgz#15967a7b577ff81383f9b888aa6705d43fbbae93"
   integrity sha512-EPpXLOVqDvisVxtlbvzfyqSsFeQxltFbluZNRndIb8tr9KiBnYNLzrc1N3pyKUCww2RNrfHDViqDWWE1LCJQtQ==
 
-"@types/node@10.12.30":
-  version "10.12.30"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-10.12.30.tgz#4c2b4f0015f214f8158a347350481322b3b29b2f"
-  integrity sha512-nsqTN6zUcm9xtdJiM9OvOJ5EF0kOI8f1Zuug27O/rgtxCRJHGqncSWfCMZUP852dCKPsDsYXGvBhxfRjDBkF5Q==
-
 "@types/node@^10.1.0":
   version "10.17.51"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-10.17.51.tgz#639538575befbcf3d3861f95c41de8e47124d674"
   integrity sha512-KANw+MkL626tq90l++hGelbl67irOJzGhUJk6a1Bt8QHOeh9tztJx+L0AqttraWKinmZn7Qi5lJZJzx45Gq0dg==
 
+"@types/node@~12.12.6":
+  version "12.12.70"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-12.12.70.tgz#adf70b179c3ee17620215ee4cb5c68c95f7c37ec"
+  integrity sha512-i5y7HTbvhonZQE+GnUM2rz1Bi8QkzxdQmEv1LKOv4nWyaQk/gdeiTApuQR3PDJHX7WomAbpx2wlWSEpxXGZ/UQ==
+
 "@types/normalize-package-data@^2.4.0":
   version "2.4.0"
   resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.0.tgz#e486d0d97396d79beedd0a6e33f4534ff6b4973e"