Skip to content

Commit aa0370a

Browse files
alan-agius4clydin
authored andcommitted
build: update build-tooling package and enable Node.js 18 tests
This commit updates the build-tooling package which contains fixes for RBE on Node.js 18. It also enables the Node.js 18 test suit.
1 parent de5c731 commit aa0370a

File tree

4 files changed

+174
-606
lines changed

4 files changed

+174
-606
lines changed

.circleci/dynamic_config.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -390,10 +390,7 @@ workflows:
390390
name: test-node<< matrix.nodeversion >>
391391
matrix:
392392
parameters:
393-
# Disable running this on Node.js 18 for now. This causes failures when using RBE.
394-
# Example: `GLIBC_2.28' not found.
395-
# Likely this is caused by outdated Ubuntu image https://github.com/angular/dev-infra/blob/main/bazel/remote-execution/BUILD.bazel#L21
396-
nodeversion: ['16']
393+
nodeversion: ['16', '18']
397394
requires:
398395
- build
399396

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"devDependencies": {
6161
"@ampproject/remapping": "2.2.1",
6262
"@angular/animations": "16.1.0-rc.0",
63-
"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#27aea082d8662d61c5a087b320c23e38f9268bfa",
63+
"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#69da084401b5724a236d7a6fe8be402ff2ea79b3",
6464
"@angular/cdk": "16.0.4",
6565
"@angular/common": "16.1.0-rc.0",
6666
"@angular/compiler": "16.1.0-rc.0",

packages/angular_devkit/build_webpack/src/webpack-dev-server/index_spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ describe('Dev Server Builder', () => {
5454
const output = (await run.result) as DevServerBuildOutput;
5555
expect(output.success).toBe(true);
5656

57-
const response = await fetch(`http://${output.address}:${output.port}/bundle.js`);
57+
const response = await fetch(`http://localhost:${output.port}/bundle.js`);
5858
expect(await response.text()).toContain(`console.log('hello world')`);
5959

6060
await run.stop();
@@ -67,7 +67,7 @@ describe('Dev Server Builder', () => {
6767
const output = (await run.result) as DevServerBuildOutput;
6868
expect(output.success).toBe(true);
6969

70-
const response = await fetch(`http://${output.address}:${output.port}/bundle.js`);
70+
const response = await fetch(`http://localhost:${output.port}/bundle.js`);
7171
expect(await response.text()).toContain(`console.log('hello world')`);
7272

7373
await run.stop();

0 commit comments

Comments
 (0)