test: use Node.js argument parser for E2E test runner

The `node:util` builtin provides an argument parser that
can be leveraged for the E2E test runner that avoids the
need for additional third-party packages.

Author: clydin

tests/legacy-cli/BUILD.bazel

@@ -15,10 +15,8 @@ ts_library(
         "//packages/angular_devkit/core",
         "//packages/angular_devkit/core/node",
         "//tests/legacy-cli/e2e/utils",
-        "@npm//@types/yargs-parser",
         "@npm//ansi-colors",
         "@npm//fast-glob",
-        "@npm//yargs-parser",
     ],
 )
 

tests/legacy-cli/e2e.bzl

@@ -83,8 +83,8 @@ def e2e_suites(name, runner, data):
 
 def _e2e_tests(name, runner, **kwargs):
     # Always specify all the npm packages
-    args = kwargs.pop("templated_args", []) + ["--package"] + [
-        "$(rootpath %s)" % p
+    args = kwargs.pop("templated_args", []) + [
+        "--package $(rootpath %s)" % p
         for p in TESTED_PACKAGES
     ]
 

tests/legacy-cli/e2e/initialize/500-create-project.ts

@@ -1,5 +1,4 @@
 import { join } from 'path';
-import yargsParser from 'yargs-parser';
 import { getGlobalVariable } from '../utils/env';
 import { expectFileToExist } from '../utils/fs';
 import { gitClean } from '../utils/git';
@@ -8,13 +7,13 @@ import { ng } from '../utils/process';
 import { prepareProjectForE2e, updateJsonFile } from '../utils/project';
 
 export default async function () {
-  const argv = getGlobalVariable<yargsParser.Arguments>('argv');
+  const argv: Record<string, unknown> = getGlobalVariable('argv');
 
   if (argv.noproject) {
     return;
   }
 
-  if (argv.reuse) {
+  if (argv.reuse && typeof argv.reuse === 'string') {
     process.chdir(argv.reuse);
     await gitClean();
   } else {

tests/legacy-cli/e2e/initialize/BUILD.bazel

@@ -10,6 +10,5 @@ ts_library(
     visibility = ["//visibility:public"],
     deps = [
         "//tests/legacy-cli/e2e/utils",
-        "@npm//@types/yargs-parser",
     ],
 )

tests/legacy-cli/e2e/utils/BUILD.bazel

@@ -11,7 +11,6 @@ ts_library(
     deps = [
         "@npm//@types/semver",
         "@npm//@types/tar",
-        "@npm//@types/yargs-parser",
         "@npm//ansi-colors",
         "@npm//fast-glob",
         "@npm//npm",

tests/legacy-cli/e2e/utils/project.ts

@@ -1,7 +1,6 @@
 import * as fs from 'fs';
 import * as path from 'path';
 import { prerelease, SemVer } from 'semver';
-import yargsParser from 'yargs-parser';
 import { getGlobalVariable } from './env';
 import { readFile, replaceInFile, writeFile } from './fs';
 import { gitCommit } from './git';
@@ -39,7 +38,7 @@ export async function ngServe(...args: string[]) {
 }
 
 export async function prepareProjectForE2e(name: string) {
-  const argv: yargsParser.Arguments = getGlobalVariable('argv');
+  const argv: Record<string, unknown> = getGlobalVariable('argv');
 
   await git('config', 'user.email', 'angular-core+e2e@google.com');
   await git('config', 'user.name', 'Angular CLI E2E');

tests/legacy-cli/e2e_runner.ts

@@ -1,7 +1,7 @@
+import { parseArgs } from 'node:util';
 import { createConsoleLogger } from '../../packages/angular_devkit/core/node';
 import colors from 'ansi-colors';
 import glob from 'fast-glob';
-import yargsParser from 'yargs-parser';
 import * as path from 'path';
 import { getGlobalVariable, setGlobalVariable } from './e2e/utils/env';
 import { gitClean } from './e2e/utils/git';
@@ -40,30 +40,44 @@ Error.stackTraceLimit = Infinity;
  *
  * If unnamed flags are passed in, the list of tests will be filtered to include only those passed.
  */
-const argv = yargsParser(process.argv.slice(2), {
-  boolean: ['debug', 'esbuild', 'ng-snapshots', 'noglobal', 'nosilent', 'noproject', 'verbose'],
-  string: ['devkit', 'glob', 'reuse', 'ng-tag', 'tmpdir', 'ng-version', 'package-manager'],
-  number: ['nb-shards', 'shard'],
-  array: ['package', 'ignore'],
-  configuration: {
-    'camel-case-expansion': false,
-    'dot-notation': false,
-  },
-  default: {
-    'package-manager': 'npm',
-    'package': ['./dist/_*.tgz'],
-    'debug': !!process.env.BUILD_WORKSPACE_DIRECTORY,
-    'glob': process.env.TESTBRIDGE_TEST_ONLY,
-    'nb-shards':
-      Number(process.env.E2E_SHARD_TOTAL ?? 1) * Number(process.env.TEST_TOTAL_SHARDS ?? 1) || 1,
-    'shard':
-      process.env.E2E_SHARD_INDEX === undefined && process.env.TEST_SHARD_INDEX === undefined
-        ? undefined
-        : Number(process.env.E2E_SHARD_INDEX ?? 0) * Number(process.env.TEST_TOTAL_SHARDS ?? 1) +
-          Number(process.env.TEST_SHARD_INDEX ?? 0),
+const parsed = parseArgs({
+  allowPositionals: true,
+  options: {
+    'debug': { type: 'boolean', default: !!process.env.BUILD_WORKSPACE_DIRECTORY },
+    'esbuild': { type: 'boolean' },
+    'glob': { type: 'string', default: process.env.TESTBRIDGE_TEST_ONLY },
+    'ignore': { type: 'string', multiple: true },
+    'ng-snapshots': { type: 'boolean' },
+    'ng-tag': { type: 'string' },
+    'ng-version': { type: 'string' },
+    'noglobal': { type: 'boolean' },
+    'noproject': { type: 'boolean' },
+    'nosilent': { type: 'boolean' },
+    'package': { type: 'string', multiple: true, default: ['./dist/_*.tgz'] },
+    'package-manager': { type: 'string', default: 'npm' },
+    'reuse': { type: 'string' },
+    'tmpdir': { type: 'string' },
+    'verbose': { type: 'boolean' },
+
+    'nb-shards': { type: 'string' },
+    'shard': { type: 'string' },
   },
 });
 
+const argv = {
+  ...parsed.values,
+  _: parsed.positionals,
+  'nb-shards':
+    parsed.values['nb-shards'] ??
+    (Number(process.env.E2E_SHARD_TOTAL ?? 1) * Number(process.env.TEST_TOTAL_SHARDS ?? 1) || 1),
+  shard:
+    parsed.values.shard ??
+    (process.env.E2E_SHARD_INDEX === undefined && process.env.TEST_SHARD_INDEX === undefined
+      ? undefined
+      : Number(process.env.E2E_SHARD_INDEX ?? 0) * Number(process.env.TEST_TOTAL_SHARDS ?? 1) +
+        Number(process.env.TEST_SHARD_INDEX ?? 0)),
+};
+
 /**
  * Set the error code of the process to 255.  This is to ensure that if something forces node
  * to exit without finishing properly, the error code will be 255. Right now that code is not used.