build: update to rxjs 7

G3 is now using RXJS version 7 which makes it possible for the CLI to also be updated to RXJS 7.

NB: this change does not remove all usages of the deprecated APIs.

Closes #24371

Author: alan-agius4

goldens/public-api/angular_devkit/architect/index.md

@@ -10,9 +10,9 @@ import { JsonObject } from '@angular-devkit/core';
 import { JsonValue } from '@angular-devkit/core';
 import { logging } from '@angular-devkit/core';
 import { Observable } from 'rxjs';
+import { ObservableInput } from 'rxjs';
 import { Observer } from 'rxjs';
 import { schema } from '@angular-devkit/core';
-import { SubscribableOrPromise } from 'rxjs';
 
 // @public (undocumented)
 export class Architect {
@@ -67,7 +67,7 @@ export type BuilderInput = json.JsonObject & Schema;
 export type BuilderOutput = json.JsonObject & Schema_2;
 
 // @public
-export type BuilderOutputLike = AsyncIterable<BuilderOutput> | SubscribableOrPromise<BuilderOutput> | BuilderOutput;
+export type BuilderOutputLike = ObservableInput<BuilderOutput> | BuilderOutput;
 
 // @public (undocumented)
 export type BuilderProgress = json.JsonObject & Schema_3 & TypedBuilderProgress;

goldens/public-api/angular_devkit/core/index.md

@@ -7,11 +7,11 @@
 import { ErrorObject } from 'ajv';
 import { Format } from 'ajv';
 import { Observable } from 'rxjs';
+import { ObservableInput } from 'rxjs';
 import { Operator } from 'rxjs';
 import { PartialObserver } from 'rxjs';
 import { Position } from 'source-map';
 import { Subject } from 'rxjs';
-import { SubscribableOrPromise } from 'rxjs';
 import { Subscription } from 'rxjs';
 import { ValidateFunction } from 'ajv';
 
@@ -715,7 +715,7 @@ interface PromptDefinition {
 }
 
 // @public (undocumented)
-type PromptProvider = (definitions: Array<PromptDefinition>) => SubscribableOrPromise<{
+type PromptProvider = (definitions: Array<PromptDefinition>) => ObservableInput<{
     [id: string]: JsonValue;
 }>;
 

package.json

@@ -191,7 +191,7 @@
     "puppeteer": "18.2.1",
     "quicktype-core": "6.0.69",
     "resolve-url-loader": "5.0.0",
-    "rxjs": "6.6.7",
+    "rxjs": "7.6.0",
     "sass": "1.56.1",
     "sass-loader": "13.2.0",
     "sauce-connect-proxy": "https://saucelabs.com/downloads/sc-4.8.1-linux.tar.gz",

packages/angular/cli/BUILD.bazel

@@ -142,7 +142,6 @@ ts_library(
         "//packages/angular_devkit/schematics",
         "//packages/angular_devkit/schematics/testing",
         "@npm//@types/semver",
-        "@npm//rxjs",
     ],
 )
 

packages/angular/cli/package.json

@@ -41,9 +41,6 @@
     "symbol-observable": "4.0.0",
     "yargs": "17.6.2"
   },
-  "devDependencies": {
-    "rxjs": "6.6.7"
-  },
   "ng-update": {
     "migrations": "@schematics/angular/migrations/migration-collection.json",
     "packageGroup": {

packages/angular/cli/src/command-builder/architect-base-command-module.ts

@@ -14,6 +14,7 @@ import {
 import { json } from '@angular-devkit/core';
 import { spawnSync } from 'child_process';
 import { existsSync } from 'fs';
+import assert from 'node:assert';
 import { resolve } from 'path';
 import { isPackageNameSafeForAnalytics } from '../analytics/analytics';
 import { EventCustomDimension, EventCustomMetric } from '../analytics/analytics-parameters';
@@ -85,7 +86,11 @@ export abstract class ArchitectBaseCommandModule<T extends object>
     }
 
     try {
-      const { error, success } = await run.output.toPromise();
+      const output = await run.output.toPromise();
+      // TODO(RXJS): temporary assert to avoid adding rxjs dependency.
+      assert(output);
+
+      const { error, success } = output;
 
       if (error) {
         logger.error(error);

packages/angular/cli/src/command-builder/utilities/json-schema.ts

@@ -7,6 +7,7 @@
  */
 
 import { json } from '@angular-devkit/core';
+import assert from 'node:assert';
 import yargs from 'yargs';
 
 /**
@@ -198,6 +199,8 @@ export async function parseJsonSchemaToOptions(
   }
 
   const flattenedSchema = await registry.flatten(schema).toPromise();
+  // TODO(RXJS): temporary assert to avoid adding rxjs dependency.
+  assert(flattenedSchema);
   json.schema.visitJsonSchema(flattenedSchema, visitor);
 
   // Sort by positional and name.