build: update E2E setup to use NPM 10 to publish packages

This commit updates the e2e setup to use the latest version of NPM to publish packages.

Author: alan-agius4

.github/dependency-review-config.yml

@@ -2,6 +2,7 @@ vulnerability_check: false
 allow_licenses:
   - '0BSD'
   - 'Apache-2.0'
+  - 'Artistic-2.0'
   - 'BlueOak-1.0.0'
   - 'BSD-2-Clause'
   - 'BSD-3-Clause'

package.json

@@ -164,7 +164,7 @@
     "mini-css-extract-plugin": "2.9.0",
     "mrmime": "2.0.0",
     "ng-packagr": "18.0.0",
-    "npm": "^8.11.0",
+    "npm": "^10.8.1",
     "npm-package-arg": "11.0.2",
     "open": "10.1.0",
     "ora": "5.4.1",

tests/legacy-cli/e2e/setup/010-local-publish.ts

@@ -1,3 +1,5 @@
+import { writeFile } from 'node:fs/promises';
+import { join } from 'node:path/posix';
 import { getGlobalVariable } from '../utils/env';
 import { PkgInfo } from '../utils/packages';
 import { globalNpm, extractNpmEnv } from '../utils/process';
@@ -6,25 +8,22 @@ import { isPrereleaseCli } from '../utils/project';
 export default async function () {
   const testRegistry: string = getGlobalVariable('package-registry');
   const packageTars: PkgInfo[] = Object.values(getGlobalVariable('package-tars'));
+  const npmrc = join(getGlobalVariable('tmp-root'), '.npmrc-publish');
+  await writeFile(
+    npmrc,
+    `
+    --registry=${testRegistry}
+    ${testRegistry.replace(/^https?:/, '')}/:_authToken=fake-secret
+    `,
+  );
 
   // Publish packages specified with --package
   await Promise.all(
     packageTars.map(({ path: p }) =>
-      globalNpm(
-        [
-          'publish',
-          `--registry=${testRegistry}`,
-          '--tag',
-          isPrereleaseCli() ? 'next' : 'latest',
-          p,
-        ],
-        {
-          ...extractNpmEnv(),
-          // Also set an auth token value for the local test registry which is required by npm 7+
-          // even though it is never actually used.
-          'NPM_CONFIG__AUTH': 'e2e-testing',
-        },
-      ),
+      globalNpm(['publish', '--tag', isPrereleaseCli() ? 'next' : 'latest', p], {
+        ...extractNpmEnv(),
+        'NPM_CONFIG_USERCONFIG': npmrc,
+      }),
     ),
   );
 }

tests/legacy-cli/e2e/utils/registry.ts

@@ -1,5 +1,6 @@
-import { spawn } from 'child_process';
-import { join } from 'path';
+import { ChildProcess, fork } from 'node:child_process';
+import { on } from 'node:events';
+import { join } from 'node:path';
 import { getGlobalVariable } from './env';
 import { writeFile, readFile } from './fs';
 import { mktempd } from './utils';
@@ -8,7 +9,7 @@ export async function createNpmRegistry(
   port: number,
   httpsPort: number,
   withAuthentication = false,
-) {
+): Promise<ChildProcess> {
   // Setup local package registry
   const registryPath = await mktempd('angular-cli-e2e-registry-');
 
@@ -17,16 +18,27 @@ export async function createNpmRegistry(
   );
   configContent = configContent.replace(/\$\{HTTP_PORT\}/g, String(port));
   configContent = configContent.replace(/\$\{HTTPS_PORT\}/g, String(httpsPort));
-  await writeFile(join(registryPath, 'verdaccio.yaml'), configContent);
+  const configPath = join(registryPath, 'verdaccio.yaml');
+  await writeFile(configPath, configContent);
 
-  return spawn(
-    process.execPath,
-    [require.resolve('verdaccio/bin/verdaccio'), '-c', './verdaccio.yaml'],
-    {
-      cwd: registryPath,
-      stdio: 'inherit',
-    },
-  );
+  const verdaccioServer = fork(require.resolve('verdaccio/bin/verdaccio'), ['-c', configPath]);
+  for await (const events of on(verdaccioServer, 'message', {
+    signal: AbortSignal.timeout(30_000),
+  })) {
+    if (
+      events.some(
+        (event: unknown) =>
+          event &&
+          typeof event === 'object' &&
+          'verdaccio_started' in event &&
+          event.verdaccio_started,
+      )
+    ) {
+      break;
+    }
+  }
+
+  return verdaccioServer;
 }
 
 // Token was generated using `echo -n 'testing:s3cret' | openssl base64`.