Skip to content

Commit 7eee544

Browse files
devversionangular-robot[bot]
authored andcommitted
build: remove ts-node forking bug workaround
In the past, `ts-node` had a bug that prevented forking processes when used in combination with `--esm`. We contributed a fix upstream to `ts-node` to fix this, and this commit updates to the latest version so that we can simplify our `ng-dev` invocation. TypeStrong/ts-node@32d07e2
1 parent e2a8e6d commit 7eee544

File tree

2 files changed

+4
-15
lines changed

2 files changed

+4
-15
lines changed

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"build": "node ./bin/devkit-admin build",
2424
"build-tsc": "tsc -p tsconfig.json",
2525
"lint": "eslint --cache --max-warnings=0 \"**/*.ts\"",
26-
"ng-dev": "cross-env TS_NODE_PROJECT=$PWD/.ng-dev/tsconfig.json TS_NODE_TRANSPILE_ONLY=1 node --no-warnings --loader ts-node/esm node_modules/@angular/ng-dev/bundles/cli.mjs",
26+
"ng-dev": "ts-node --esm --project .ng-dev/tsconfig.json --transpile-only node_modules/@angular/ng-dev/bundles/cli.mjs",
2727
"templates": "node ./bin/devkit-admin templates",
2828
"validate": "node ./bin/devkit-admin validate",
2929
"postinstall": "yarn webdriver-update && yarn husky install",
@@ -139,7 +139,6 @@
139139
"chokidar": "3.5.3",
140140
"copy-webpack-plugin": "11.0.0",
141141
"critters": "0.0.16",
142-
"cross-env": "^7.0.3",
143142
"css-loader": "6.7.3",
144143
"debug": "^4.1.1",
145144
"esbuild": "0.17.11",
@@ -208,7 +207,7 @@
208207
"terser": "5.16.5",
209208
"text-table": "0.2.0",
210209
"tree-kill": "1.2.2",
211-
"ts-node": "^10.0.0",
210+
"ts-node": "^10.9.1",
212211
"tslib": "2.5.0",
213212
"typescript": "5.0.0-beta",
214213
"verdaccio": "5.22.0",

yarn.lock

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@
122122

123123
"@angular/build-tooling@https://github.com/angular/dev-infra-private-build-tooling-builds.git#94de580a2cc6e2cd71df8e842e457e014ff2c17e":
124124
version "0.0.0-fc4d34a1a8d30c197533a51c9af1bb52c9356094"
125-
uid "94de580a2cc6e2cd71df8e842e457e014ff2c17e"
126125
resolved "https://github.com/angular/dev-infra-private-build-tooling-builds.git#94de580a2cc6e2cd71df8e842e457e014ff2c17e"
127126
dependencies:
128127
"@angular-devkit/build-angular" "16.0.0-next.2"
@@ -306,7 +305,6 @@
306305

307306
"@angular/ng-dev@https://github.com/angular/dev-infra-private-ng-dev-builds.git#effa74d6286182912319fe8cf1feb7df0fab51dd":
308307
version "0.0.0-fc4d34a1a8d30c197533a51c9af1bb52c9356094"
309-
uid effa74d6286182912319fe8cf1feb7df0fab51dd
310308
resolved "https://github.com/angular/dev-infra-private-ng-dev-builds.git#effa74d6286182912319fe8cf1feb7df0fab51dd"
311309
dependencies:
312310
"@yarnpkg/lockfile" "^1.1.0"
@@ -5039,21 +5037,14 @@ critters@0.0.16:
50395037
postcss "^8.3.7"
50405038
pretty-bytes "^5.3.0"
50415039

5042-
cross-env@^7.0.3:
5043-
version "7.0.3"
5044-
resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-7.0.3.tgz#865264b29677dc015ba8418918965dd232fc54cf"
5045-
integrity sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw==
5046-
dependencies:
5047-
cross-spawn "^7.0.1"
5048-
50495040
cross-fetch@3.1.5, cross-fetch@^3.1.5:
50505041
version "3.1.5"
50515042
resolved "https://registry.yarnpkg.com/cross-fetch/-/cross-fetch-3.1.5.tgz#e1389f44d9e7ba767907f7af8454787952ab534f"
50525043
integrity sha512-lvb1SBsI0Z7GDwmuid+mU3kWVBwTVUbe7S0H52yaaAdQOXq2YktTCZdlAcNKFzE6QtRz0snpw9bNiPeOIkkQvw==
50535044
dependencies:
50545045
node-fetch "2.6.7"
50555046

5056-
cross-spawn@^7.0.0, cross-spawn@^7.0.1, cross-spawn@^7.0.2, cross-spawn@^7.0.3:
5047+
cross-spawn@^7.0.0, cross-spawn@^7.0.2, cross-spawn@^7.0.3:
50575048
version "7.0.3"
50585049
resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-7.0.3.tgz#f73a85b9d5d41d045551c177e2882d4ac85728a6"
50595050
integrity sha512-iRDPJKUPVEND7dHPO8rkbOnPpyDygcDFtWjpeWNCgy8WP2rXcxXL8TskReQl6OrB2G7+UJrags1q15Fudc7G6w==
@@ -10042,7 +10033,6 @@ sass@1.58.3, sass@^1.55.0:
1004210033

1004310034
"sauce-connect-proxy@https://saucelabs.com/downloads/sc-4.8.1-linux.tar.gz":
1004410035
version "0.0.0"
10045-
uid "9c16682e4c9716734432789884f868212f95f563"
1004610036
resolved "https://saucelabs.com/downloads/sc-4.8.1-linux.tar.gz#9c16682e4c9716734432789884f868212f95f563"
1004710037

1004810038
saucelabs@^1.5.0:
@@ -10892,7 +10882,7 @@ treeverse@^2.0.0:
1089210882
resolved "https://registry.yarnpkg.com/true-case-path/-/true-case-path-2.2.1.tgz#c5bf04a5bbec3fd118be4084461b3a27c4d796bf"
1089310883
integrity sha512-0z3j8R7MCjy10kc/g+qg7Ln3alJTodw9aDuVWZa3uiWqfuBMKeAeP2ocWcxoyM3D73yz3Jt/Pu4qPr4wHSdB/Q==
1089410884

10895-
ts-node@^10.0.0:
10885+
ts-node@^10.9.1:
1089610886
version "10.9.1"
1089710887
resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-10.9.1.tgz#e73de9102958af9e1f0b168a6ff320e25adcff4b"
1089810888
integrity sha512-NtVysVPkxxrwFGUUxGYhfux8k78pQB3JqYBXlLRZgdGUqTO5wU/UyHop5p70iEbGhB7q5KmiZiU0Y3KlJrScEw==

0 commit comments

Comments
 (0)