Skip to content

Commit 7e7fe8b

Browse files
committed
refactor(@angular/build): use latest inquirer prompt package
The `inquirer` package has been rewritten with a new set of packages. The rewrite had a focus on reduced package size and improved performance. The main prompt package is now `@inquirer/prompts`. However, for `@angular/build` only the confirm prompt is needed so the `@inquirer/confirm` package can be used directly to further reduce dependencies.
1 parent b411b98 commit 7e7fe8b

File tree

5 files changed

+10
-13
lines changed

5 files changed

+10
-13
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@
8383
"@bazel/esbuild": "5.8.1",
8484
"@bazel/jasmine": "5.8.1",
8585
"@discoveryjs/json-ext": "0.5.7",
86+
"@inquirer/confirm": "3.1.9",
8687
"@inquirer/prompts": "5.0.5",
8788
"@rollup/plugin-commonjs": "^26.0.0",
8889
"@rollup/plugin-node-resolve": "^13.0.5",

packages/angular/build/BUILD.bazel

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ ts_library(
6767
"@npm//@babel/core",
6868
"@npm//@babel/helper-annotate-as-pure",
6969
"@npm//@babel/helper-split-export-declaration",
70+
"@npm//@inquirer/confirm",
7071
"@npm//@types/babel__core",
7172
"@npm//@types/browserslist",
72-
"@npm//@types/inquirer",
7373
"@npm//@types/less",
7474
"@npm//@types/node",
7575
"@npm//@types/picomatch",
@@ -82,7 +82,6 @@ ts_library(
8282
"@npm//esbuild",
8383
"@npm//fast-glob",
8484
"@npm//https-proxy-agent",
85-
"@npm//inquirer",
8685
"@npm//lmdb",
8786
"@npm//magic-string",
8887
"@npm//mrmime",

packages/angular/build/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@
2323
"@babel/core": "7.24.7",
2424
"@babel/helper-annotate-as-pure": "7.24.7",
2525
"@babel/helper-split-export-declaration": "7.24.7",
26+
"@inquirer/confirm": "3.1.9",
2627
"@vitejs/plugin-basic-ssl": "1.1.0",
2728
"ansi-colors": "4.1.3",
2829
"browserslist": "^4.23.0",
2930
"critters": "0.0.22",
3031
"esbuild": "0.21.4",
3132
"fast-glob": "3.3.2",
3233
"https-proxy-agent": "7.0.4",
33-
"inquirer": "9.2.23",
3434
"lmdb": "3.0.11",
3535
"magic-string": "0.30.10",
3636
"mrmime": "2.0.0",

packages/angular/build/src/utils/check-port.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
*/
88

99
import assert from 'node:assert';
10-
import { AddressInfo, createServer } from 'node:net';
11-
import { loadEsmModule } from './load-esm';
10+
import { createServer } from 'node:net';
1211
import { isTTY } from './tty';
1312

1413
function createInUseError(port: number): Error {
@@ -39,18 +38,16 @@ export async function checkPort(port: number, host: string): Promise<number> {
3938
return;
4039
}
4140

42-
loadEsmModule<typeof import('inquirer')>('inquirer')
43-
.then(({ default: { prompt } }) =>
44-
prompt({
45-
type: 'confirm',
46-
name: 'useDifferent',
41+
import('@inquirer/confirm')
42+
.then(({ default: confirm }) =>
43+
confirm({
4744
message: `Port ${port} is already in use.\nWould you like to use a different port?`,
4845
default: true,
46+
theme: { prefix: '' },
4947
}),
5048
)
5149
.then(
52-
(answers) =>
53-
answers.useDifferent ? resolve(checkPort(0, host)) : reject(createInUseError(port)),
50+
(answer) => (answer ? resolve(checkPort(0, host)) : reject(createInUseError(port))),
5451
() => reject(createInUseError(port)),
5552
);
5653
})

yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1948,7 +1948,7 @@
19481948
ansi-escapes "^4.3.2"
19491949
chalk "^4.1.2"
19501950

1951-
"@inquirer/confirm@^3.1.9":
1951+
"@inquirer/confirm@3.1.9", "@inquirer/confirm@^3.1.9":
19521952
version "3.1.9"
19531953
resolved "https://registry.yarnpkg.com/@inquirer/confirm/-/confirm-3.1.9.tgz#1bc384bc8267827ec75d0684e189692bb4dda38b"
19541954
integrity sha512-UF09aejxCi4Xqm6N/jJAiFXArXfi9al52AFaSD+2uIHnhZGtd1d6lIGTRMPouVSJxbGEi+HkOWSYaiEY/+szUw==

0 commit comments

Comments
 (0)