Skip to content

Commit 5ec624e

Browse files
alan-agius4clydin
authored andcommitted
ci: configure bazel to ignore vite tests when using non esbuild tests
This commit configures bazel to skip adding vite tests to the webpack tests shards.
1 parent 286e5d3 commit 5ec624e

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

tests/legacy-cli/e2e.bzl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ ESBUILD_TESTS = [
3838
"tests/test/**",
3939
]
4040

41+
WEBPACK_IGNORE_TESTS = [
42+
"tests/vite/**",
43+
]
44+
4145
def _to_glob(patterns):
4246
if len(patterns) == 1:
4347
return patterns[0]
@@ -126,7 +130,7 @@ def _e2e_suite(name, runner, type, data, toolchain_name = "", toolchain = None):
126130
if type == "yarn":
127131
args.append("--yarn")
128132
tests = YARN_TESTS
129-
ignore = BROWSER_TESTS
133+
ignore = BROWSER_TESTS + WEBPACK_IGNORE_TESTS
130134
elif type == "esbuild":
131135
args.append("--esbuild")
132136
tests = ESBUILD_TESTS
@@ -137,7 +141,7 @@ def _e2e_suite(name, runner, type, data, toolchain_name = "", toolchain = None):
137141
ignore = None
138142
elif type == "npm":
139143
tests = None
140-
ignore = BROWSER_TESTS
144+
ignore = BROWSER_TESTS + WEBPACK_IGNORE_TESTS
141145

142146
# Standard e2e tests
143147
_e2e_tests(

tests/legacy-cli/e2e/tests/vite/reuse-dep-optimization-cache.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,8 @@ import { setTimeout } from 'node:timers/promises';
22
import assert from 'node:assert';
33
import { findFreePort } from '../../utils/network';
44
import { execAndWaitForOutputToMatch, killAllProcesses, ng } from '../../utils/process';
5-
import { getGlobalVariable } from '../../utils/env';
65

76
export default async function () {
8-
const useWebpackBuilder = !getGlobalVariable('argv')['esbuild'];
9-
if (useWebpackBuilder) {
10-
return;
11-
}
12-
137
await ng('cache', 'clean');
148
await ng('cache', 'on');
159

0 commit comments

Comments
 (0)