Skip to content

Commit 429f56b

Browse files
clydinangular-robot[bot]
authored andcommitted
test: ensure esbuild and yarn E2E tests are executed
The additional arguments were previously not fully propagated within the bazel rules.
1 parent d50c038 commit 429f56b

File tree

6 files changed

+47
-16
lines changed

6 files changed

+47
-16
lines changed

packages/angular_devkit/build_angular/src/builders/browser-esbuild/css-plugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export function createCssPlugin(options: CssPluginOptions): Plugin {
7171
const postcssProcessor = postcss();
7272
if (options.tailwindConfiguration) {
7373
const tailwind = await import(options.tailwindConfiguration.package);
74-
postcssProcessor.use(tailwind({ config: options.tailwindConfiguration.file }));
74+
postcssProcessor.use(tailwind.default({ config: options.tailwindConfiguration.file }));
7575
}
7676
if (!skipAutoprefixer) {
7777
postcssProcessor.use(autoprefixer);

packages/angular_devkit/build_angular/src/builders/browser-esbuild/options.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ export async function normalizeOptions(
9191
let tailwindConfiguration: { file: string; package: string } | undefined;
9292
const tailwindConfigurationPath = findTailwindConfigurationFile(workspaceRoot, projectRoot);
9393
if (tailwindConfigurationPath) {
94-
const resolver = createRequire(projectRoot);
94+
// Create a node resolver at the project root as a directory
95+
const resolver = createRequire(projectRoot + '/');
9596
try {
9697
tailwindConfiguration = {
9798
file: tailwindConfigurationPath,

tests/legacy-cli/e2e.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ def _e2e_suite(name, runner, type, data, toolchain_name = "", toolchain = None):
155155
data = data,
156156
toolchain = toolchain,
157157
shard_count = TEST_SHARD_COUNT,
158-
templated_args = [
158+
templated_args = args + [
159159
"--glob=%s" % _to_glob(tests) if tests else "",
160160
"--ignore=%s" % _to_glob(ignore) if ignore else "",
161161
],

tests/legacy-cli/e2e/tests/build/styles/tailwind-v2.ts

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,14 @@ export default async function () {
2424
}
2525

2626
// Tailwind directives should be unprocessed with missing package
27-
await expectFileToMatch('dist/test-project/styles.css', '@tailwind base; @tailwind components;');
28-
await expectFileToMatch('dist/test-project/main.js', '@tailwind base; @tailwind components;');
27+
await expectFileToMatch(
28+
'dist/test-project/styles.css',
29+
/@tailwind base;\s+@tailwind components;/,
30+
);
31+
await expectFileToMatch(
32+
'dist/test-project/main.js',
33+
/@tailwind base;(?:\\n|\s*)@tailwind components;/,
34+
);
2935

3036
// Install Tailwind
3137
await installPackage('tailwindcss@2');
@@ -37,19 +43,28 @@ export default async function () {
3743
await expectFileToMatch('dist/test-project/styles.css', /::placeholder/);
3844
await expectFileToMatch('dist/test-project/main.js', /::placeholder/);
3945
await expectToFail(() =>
40-
expectFileToMatch('dist/test-project/styles.css', '@tailwind base; @tailwind components;'),
46+
expectFileToMatch('dist/test-project/styles.css', /@tailwind base;\s+@tailwind components;/),
4147
);
4248
await expectToFail(() =>
43-
expectFileToMatch('dist/test-project/main.js', '@tailwind base; @tailwind components;'),
49+
expectFileToMatch(
50+
'dist/test-project/main.js',
51+
/@tailwind base;(?:\\n|\s*)@tailwind components;/,
52+
),
4453
);
4554

4655
// Remove configuration file
4756
await deleteFile('tailwind.config.js');
4857

4958
// Ensure Tailwind is disabled when no configuration file is present
5059
await ng('build', '--configuration=development');
51-
await expectFileToMatch('dist/test-project/styles.css', '@tailwind base; @tailwind components;');
52-
await expectFileToMatch('dist/test-project/main.js', '@tailwind base; @tailwind components;');
60+
await expectFileToMatch(
61+
'dist/test-project/styles.css',
62+
/@tailwind base;\s+@tailwind components;/,
63+
);
64+
await expectFileToMatch(
65+
'dist/test-project/main.js',
66+
/@tailwind base;(?:\\n|\s*)@tailwind components;/,
67+
);
5368

5469
// Uninstall Tailwind
5570
await uninstallPackage('tailwindcss');

tests/legacy-cli/e2e/tests/build/styles/tailwind-v3-cjs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export default async function () {
2929
// Check for Tailwind output
3030
await expectFileToMatch('dist/test-project/styles.css', /::placeholder/);
3131
await expectToFail(() =>
32-
expectFileToMatch('dist/test-project/styles.css', '@tailwind base; @tailwind components;'),
32+
expectFileToMatch('dist/test-project/styles.css', /@tailwind base;\s+@tailwind components;/),
3333
);
3434

3535
// Uninstall Tailwind

tests/legacy-cli/e2e/tests/build/styles/tailwind-v3.ts

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,14 @@ export default async function () {
2424
}
2525

2626
// Tailwind directives should be unprocessed with missing package
27-
await expectFileToMatch('dist/test-project/styles.css', '@tailwind base; @tailwind components;');
28-
await expectFileToMatch('dist/test-project/main.js', '@tailwind base; @tailwind components;');
27+
await expectFileToMatch(
28+
'dist/test-project/styles.css',
29+
/@tailwind base;\s+@tailwind components;/,
30+
);
31+
await expectFileToMatch(
32+
'dist/test-project/main.js',
33+
/@tailwind base;(?:\\n|\s*)@tailwind components;/,
34+
);
2935

3036
// Install Tailwind
3137
await installPackage('tailwindcss@3');
@@ -37,19 +43,28 @@ export default async function () {
3743
await expectFileToMatch('dist/test-project/styles.css', /::placeholder/);
3844
await expectFileToMatch('dist/test-project/main.js', /::placeholder/);
3945
await expectToFail(() =>
40-
expectFileToMatch('dist/test-project/styles.css', '@tailwind base; @tailwind components;'),
46+
expectFileToMatch('dist/test-project/styles.css', /@tailwind base;\s+@tailwind components;/),
4147
);
4248
await expectToFail(() =>
43-
expectFileToMatch('dist/test-project/main.js', '@tailwind base; @tailwind components;'),
49+
expectFileToMatch(
50+
'dist/test-project/main.js',
51+
/@tailwind base;(?:\\n|\s*)@tailwind components;/,
52+
),
4453
);
4554

4655
// Remove configuration file
4756
await deleteFile('tailwind.config.js');
4857

4958
// Ensure Tailwind is disabled when no configuration file is present
5059
await ng('build', '--configuration=development');
51-
await expectFileToMatch('dist/test-project/styles.css', '@tailwind base; @tailwind components;');
52-
await expectFileToMatch('dist/test-project/main.js', '@tailwind base; @tailwind components;');
60+
await expectFileToMatch(
61+
'dist/test-project/styles.css',
62+
/@tailwind base;\s+@tailwind components;/,
63+
);
64+
await expectFileToMatch(
65+
'dist/test-project/main.js',
66+
/@tailwind base;(?:\\n|\s*)@tailwind components;/,
67+
);
5368

5469
// Uninstall Tailwind
5570
await uninstallPackage('tailwindcss');

0 commit comments

Comments
 (0)