Skip to content

Commit 4100402

Browse files
devversionclydin
authored andcommitted
build: rename //:node_modules to root modules
In our dev-infra sync we decided that we want to have less ambiguous naming for node modules from the workspace root vs. node modules that are local to the package. Consider the confusion between: `//:node_modules` and `:node_modules`. This commit fixes this by naming the workspace `node_modules` as `:root_modules`. This does not have an effect on runtime of NodeJS output because `rules_js` continues to lay out the root modules as `/node_modules` folder; as it should.
1 parent 6006f59 commit 4100402

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

BUILD.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@ exports_files([
2323
])
2424

2525
npm_link_all_packages(
26-
name = "node_modules",
26+
name = "root_modules",
2727
)
2828

2929
rules_js_tsconfig(
3030
name = "build-tsconfig",
3131
src = "tsconfig-build.json",
3232
deps = [
3333
"tsconfig.json",
34-
"//:node_modules/@types/node",
34+
"//:root_modules/@types/node",
3535
],
3636
)
3737

@@ -40,7 +40,7 @@ rules_js_tsconfig(
4040
src = "tsconfig-test.json",
4141
deps = [
4242
"tsconfig.json",
43-
"//:node_modules/@types/node",
43+
"//:root_modules/@types/node",
4444
],
4545
)
4646

packages/angular_devkit/architect/BUILD.bazel

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ ts_project(
7070
],
7171
module_name = "@angular-devkit/architect",
7272
deps = [
73-
"//:node_modules/@types/node",
74-
"//:node_modules/rxjs",
73+
"//:root_modules/@types/node",
74+
"//:root_modules/rxjs",
7575
],
7676
)
7777

@@ -84,8 +84,8 @@ ts_project(
8484
],
8585
deps = [
8686
":architect_rjs",
87-
"//:node_modules/@types/jasmine",
88-
"//:node_modules/rxjs",
87+
"//:root_modules/@types/jasmine",
88+
"//:root_modules/rxjs",
8989
"//packages/angular_devkit/architect/testing:testing_rjs",
9090
],
9191
)

packages/angular_devkit/architect/testing/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ ts_project(
2222
],
2323
module_name = "@angular-devkit/architect/testing",
2424
deps = [
25-
"//:node_modules/@types/node",
26-
"//:node_modules/rxjs",
25+
"//:root_modules/@types/node",
26+
"//:root_modules/rxjs",
2727
],
2828
)

0 commit comments

Comments
 (0)