refactor(@angular-devkit/build-angular): remove unused plugin from server polyfills

alan-agius4 · alan-agius4 · commit 2dbc7b99cdec · 2023-11-13T08:28:15.000+01:00
RxJs is not imported in the server polyfills and thus we can safely remove this plugin.
diff --git a/packages/angular_devkit/build_angular/src/tools/esbuild/application-code-bundle.ts b/packages/angular_devkit/build_angular/src/tools/esbuild/application-code-bundle.ts
@@ -282,7 +282,6 @@ export function createServerPolyfillBundleOptions(
     return;
   }
 
-  const { workspaceRoot } = options;
   const buildOptions: BuildOptions = {
     ...polyfillBundleOptions,
     platform: 'node',
@@ -307,9 +306,6 @@ export function createServerPolyfillBundleOptions(
     },
   };
 
-  buildOptions.plugins ??= [];
-  buildOptions.plugins.push(createRxjsEsmResolutionPlugin());
-
   return () => buildOptions;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,6 @@ export function createServerPolyfillBundleOptions(`
`282`	`282`	`return;`
`283`	`283`	`}`
`284`	`284`
`285`		`- const { workspaceRoot } = options;`
`286`	`285`	`const buildOptions: BuildOptions = {`
`287`	`286`	`...polyfillBundleOptions,`
`288`	`287`	`platform: 'node',`
`@@ -307,9 +306,6 @@ export function createServerPolyfillBundleOptions(`
`307`	`306`	`},`
`308`	`307`	`};`
`309`	`308`
`310`		`- buildOptions.plugins ??= [];`
`311`		`- buildOptions.plugins.push(createRxjsEsmResolutionPlugin());`
`312`		`-`
`313`	`309`	`return () => buildOptions;`
`314`	`310`	`}`
`315`	`311`