Skip to content

Commit 28bdbeb

Browse files
committed
revert: fix(@angular/build): show error when Node.js built-ins are used during ng serve
This commit reverts 06f478b Closes: #29077
1 parent e126bf9 commit 28bdbeb

File tree

2 files changed

+0
-46
lines changed

2 files changed

+0
-46
lines changed

packages/angular/build/src/tools/vite/utils.ts

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -69,26 +69,6 @@ export function getDepOptimizationConfig({
6969
thirdPartySourcemaps: boolean;
7070
}): DepOptimizationConfig {
7171
const plugins: ViteEsBuildPlugin[] = [
72-
{
73-
name: 'angular-browser-node-built-in',
74-
setup(build) {
75-
// This namespace is configured by vite.
76-
// @see: https://github.com/vitejs/vite/blob/a1dd396da856401a12c921d0cd2c4e97cb63f1b5/packages/vite/src/node/optimizer/esbuildDepPlugin.ts#L109
77-
build.onLoad({ filter: /.*/, namespace: 'browser-external' }, (args) => {
78-
if (!isBuiltin(args.path)) {
79-
return;
80-
}
81-
82-
return {
83-
errors: [
84-
{
85-
text: `The package "${args.path}" wasn't found on the file system but is built into node.`,
86-
},
87-
],
88-
};
89-
});
90-
},
91-
},
9272
{
9373
name: `angular-vite-optimize-deps${ssr ? '-ssr' : ''}${
9474
thirdPartySourcemaps ? '-vendor-sourcemap' : ''

tests/legacy-cli/e2e/tests/vite/browser-node-module-dep-error.ts

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)