Travis commit : build 521

Author: AngularUI (via TravisCI)

bower.json

@@ -1,10 +1,10 @@
 {
   "name": "angular-ui-sortable",
-  "version": "0.17.0",
+  "version": "0.14.4",
   "main": ["./sortable.js"],
   "dependencies": {
     "angular": ">=1.2.x",
-    "jquery": ">=3.1.x",
-    "jquery-ui": ">=1.12.x"
+    "jquery": "<3.0.0",
+    "jquery-ui": ">=1.9"
   }
 }

sortable.js

@@ -1,6 +1,6 @@
 /**
  * angular-ui-sortable - This directive allows you to jQueryUI Sortable.
- * @version v0.17.0 - 2017-03-08
+ * @version v0.14.4 - 2017-04-15
  * @link http://angular-ui.github.com
  * @license MIT
  */
@@ -23,28 +23,14 @@ angular.module('ui.sortable', [])
     'uiSortableConfig', '$timeout', '$log',
     function(uiSortableConfig, $timeout, $log) {
       return {
-        require:'?ngModel',
+        require: '?ngModel',
         scope: {
-          ngModel:'=',
-          uiSortable:'=',
-          ////Expression bindings from html.
-          create:'&uiSortableCreate',
-          // helper:'&uiSortableHelper',
-          start:'&uiSortableStart',
-          activate:'&uiSortableActivate',
-          // sort:'&uiSortableSort',
-          // change:'&uiSortableChange',
-          // over:'&uiSortableOver',
-          // out:'&uiSortableOut',
-          beforeStop:'&uiSortableBeforeStop',
-          update:'&uiSortableUpdate',
-          remove:'&uiSortableRemove',
-          receive:'&uiSortableReceive',
-          deactivate:'&uiSortableDeactivate',
-          stop:'&uiSortableStop'
+          ngModel: '=',
+          uiSortable: '='
         },
         link: function(scope, element, attrs, ngModel) {
           var savedNodes;
+          var helper;
 
           function combineCallbacks(first, second){
             var firstIsFunc = typeof first === 'function';
@@ -121,7 +107,7 @@ angular.module('ui.sortable', [])
                     }
                     return;
                   }
-
+                  
                   if (!defaultOptions) {
                     defaultOptions = angular.element.ui.sortable().options;
                   }
@@ -194,13 +180,12 @@ angular.module('ui.sortable', [])
             return helperOption === 'clone' || (typeof helperOption === 'function' && ui.item.sortable.isCustomHelperUsed());
           }
 
-          function getSortingHelper (element, ui, savedNodes) {
+          function getSortingHelper (element, ui/*, savedNodes*/) {
             var result = null;
             if (hasSortingHelper(element, ui) &&
                 element.sortable( 'option', 'appendTo' ) === 'parent') {
               // The .ui-sortable-helper element (that's the default class name)
-              // is placed last.
-              result = savedNodes.last();
+              result = helper;
             }
             return result;
           }
@@ -210,13 +195,16 @@ angular.module('ui.sortable', [])
             return (/left|right/).test(item.css('float')) || (/inline|table-cell/).test(item.css('display'));
           }
 
-          function getElementContext(elementScopes, element) {
+          function getElementScope(elementScopes, element) {
+            var result = null;
             for (var i = 0; i < elementScopes.length; i++) {
-              var c = elementScopes[i];
-              if (c.element[0] === element[0]) {
-                return c;
+              var x = elementScopes[i];
+              if (x.element[0] === element[0]) {
+                result = x.scope;
+                break;
               }
             }
+            return result;
           }
 
           function afterStop(e, ui) {
@@ -241,19 +229,11 @@ angular.module('ui.sortable', [])
           };
 
           var callbacks = {
-            create: null,
-            start: null,
-            activate: null,
-            // sort: null,
-            // change: null,
-            // over: null,
-            // out: null,
-            beforeStop: null,
-            update: null,
-            remove: null,
             receive: null,
-            deactivate: null,
-            stop: null
+            remove: null,
+            start: null,
+            stop: null,
+            update: null
           };
 
           var wrappers = {
@@ -295,8 +275,7 @@ angular.module('ui.sortable', [])
               ui.item.sortable = {
                 model: ngModel.$modelValue[index],
                 index: index,
-                source: element,
-                sourceList: ui.item.parent(),
+                source: ui.item.parent(),
                 sourceModel: ngModel.$modelValue,
                 cancel: function () {
                   ui.item.sortable._isCanceled = true;
@@ -313,33 +292,17 @@ angular.module('ui.sortable', [])
                   angular.forEach(ui.item.sortable, function(value, key) {
                     ui.item.sortable[key] = undefined;
                   });
-                },
-                _connectedSortables: [],
-                _getElementContext: function (element) {
-                  return getElementContext(this._connectedSortables, element);
                 }
               };
             };
 
             callbacks.activate = function(e, ui) {
-              var isSourceContext = ui.item.sortable.source === element;
-              var savedNodesOrigin = isSourceContext ?
-                                     ui.item.sortable.sourceList :
-                                     element;
-              var elementContext = {
-                element: element,
-                scope: scope,
-                isSourceContext: isSourceContext,
-                savedNodesOrigin: savedNodesOrigin
-              };
-              // save the directive's scope so that it is accessible from ui.item.sortable
-              ui.item.sortable._connectedSortables.push(elementContext);
-
               // We need to make a copy of the current element's contents so
               // we can restore it after sortable has messed it up.
               // This is inside activate (instead of start) in order to save
               // both lists when dragging between connected lists.
-              savedNodes = savedNodesOrigin.contents();
+              savedNodes = element.contents();
+              helper = ui.helper;
 
               // If this list has a placeholder (the connected lists won't),
               // don't inlcude it in saved nodes.
@@ -348,20 +311,29 @@ angular.module('ui.sortable', [])
                 var excludes = getPlaceholderExcludesludes(element, placeholder);
                 savedNodes = savedNodes.not(excludes);
               }
+
+              // save the directive's scope so that it is accessible from ui.item.sortable
+              var connectedSortables = ui.item.sortable._connectedSortables || [];
+
+              connectedSortables.push({
+                element: element,
+                scope: scope
+              });
+
+              ui.item.sortable._connectedSortables = connectedSortables;
             };
 
             callbacks.update = function(e, ui) {
               // Save current drop position but only if this is not a second
               // update that happens when moving between lists because then
               // the value will be overwritten with the old value
-              if (!ui.item.sortable.received) {
+              if(!ui.item.sortable.received) {
                 ui.item.sortable.dropindex = getItemIndex(ui.item);
-                var droptarget = ui.item.closest('[ui-sortable], [data-ui-sortable], [x-ui-sortable]');
+                var droptarget = ui.item.parent();
                 ui.item.sortable.droptarget = droptarget;
-                ui.item.sortable.droptargetList = ui.item.parent();
 
-                var droptargetContext = ui.item.sortable._getElementContext(droptarget);
-                ui.item.sortable.droptargetModel = droptargetContext.scope.ngModel;
+                var droptargetScope = getElementScope(ui.item.sortable._connectedSortables, droptarget);
+                ui.item.sortable.droptargetModel = droptargetScope.ngModel;
 
                 // Cancel the sort (let ng-repeat do the sort for us)
                 // Don't cancel if this is the received list because it has
@@ -381,65 +353,61 @@ angular.module('ui.sortable', [])
                 // That way it will be garbage collected.
                 savedNodes = savedNodes.not(sortingHelper);
               }
-              var elementContext = ui.item.sortable._getElementContext(element);
-              savedNodes.appendTo(elementContext.savedNodesOrigin);
+              savedNodes.appendTo(element);
 
               // If this is the target connected list then
               // it's safe to clear the restored nodes since:
               // update is currently running and
               // stop is not called for the target list.
-              if (ui.item.sortable.received) {
+              if(ui.item.sortable.received) {
                 savedNodes = null;
               }
 
               // If received is true (an item was dropped in from another list)
               // then we add the new item to this list otherwise wait until the
               // stop event where we will know if it was a sort or item was
               // moved here from another list
-              if (ui.item.sortable.received && !ui.item.sortable.isCanceled()) {
+              if(ui.item.sortable.received && !ui.item.sortable.isCanceled()) {
                 scope.$apply(function () {
                   ngModel.$modelValue.splice(ui.item.sortable.dropindex, 0,
                                              ui.item.sortable.moved);
                 });
-                scope.$emit('ui-sortable:moved', ui);
               }
             };
 
             callbacks.stop = function(e, ui) {
               // If the received flag hasn't be set on the item, this is a
               // normal sort, if dropindex is set, the item was moved, so move
               // the items in the list.
-              var wasMoved = ('dropindex' in ui.item.sortable) &&
-                              !ui.item.sortable.isCanceled();
-
-              if (wasMoved && !ui.item.sortable.received) {
+              if(!ui.item.sortable.received &&
+                 ('dropindex' in ui.item.sortable) &&
+                 !ui.item.sortable.isCanceled()) {
 
                 scope.$apply(function () {
                   ngModel.$modelValue.splice(
                     ui.item.sortable.dropindex, 0,
                     ngModel.$modelValue.splice(ui.item.sortable.index, 1)[0]);
                 });
-                scope.$emit('ui-sortable:moved', ui);
-              } else if (!wasMoved &&
-                         !angular.equals(element.contents().toArray(), savedNodes.toArray())) {
-                // if the item was not moved
-                // and the DOM element order has changed,
-                // then restore the elements
+              } else {
+                // if the item was not moved, then restore the elements
                 // so that the ngRepeat's comment are correct.
-
-                var sortingHelper = getSortingHelper(element, ui, savedNodes);
-                if (sortingHelper && sortingHelper.length) {
-                  // Restore all the savedNodes except from the sorting helper element.
-                  // That way it will be garbage collected.
-                  savedNodes = savedNodes.not(sortingHelper);
+                if ((!('dropindex' in ui.item.sortable) || ui.item.sortable.isCanceled()) &&
+                    !angular.equals(element.contents(), savedNodes)) {
+
+                  var sortingHelper = getSortingHelper(element, ui, savedNodes);
+                  if (sortingHelper && sortingHelper.length) {
+                    // Restore all the savedNodes except from the sorting helper element.
+                    // That way it will be garbage collected.
+                    savedNodes = savedNodes.not(sortingHelper);
+                  }
+                  savedNodes.appendTo(element);
                 }
-                var elementContext = ui.item.sortable._getElementContext(element);
-                savedNodes.appendTo(elementContext.savedNodesOrigin);
               }
 
-              // It's now safe to clear the savedNodes
+              // It's now safe to clear the savedNodes and helper
               // since stop is the last callback.
               savedNodes = null;
+              helper = null;
             };
 
             callbacks.receive = function(e, ui) {
@@ -467,21 +435,6 @@ angular.module('ui.sortable', [])
               }
             };
 
-            // setup attribute handlers
-            angular.forEach(callbacks, function(value, key) {
-              callbacks[key] = combineCallbacks(callbacks[key],
-                function () {
-                  var attrHandler = scope[key];
-                  var attrHandlerFn;
-                  if (typeof attrHandler === 'function' &&
-                      ('uiSortable' + key.substring(0,1).toUpperCase() + key.substring(1)).length &&
-                      typeof (attrHandlerFn = attrHandler()) === 'function') {
-                    attrHandlerFn.apply(this, arguments);
-                  }
-                });
-            });
-
-
             wrappers.helper = function (inner) {
               if (inner && typeof inner === 'function') {
                 return function (e, item) {
@@ -490,8 +443,7 @@ angular.module('ui.sortable', [])
                   item.sortable = {
                     model: ngModel.$modelValue[index],
                     index: index,
-                    source: element,
-                    sourceList: item.parent(),
+                    source: item.parent(),
                     sourceModel: ngModel.$modelValue,
                     _restore: function () {
                       angular.forEach(item.sortable, function(value, key) {
@@ -517,7 +469,7 @@ angular.module('ui.sortable', [])
               var sortableWidgetInstance = getSortableWidgetInstance(element);
               if (!!sortableWidgetInstance) {
                 var optsDiff = patchUISortableOptions(newVal, oldVal, sortableWidgetInstance);
-
+                
                 if (optsDiff) {
                   element.sortable('option', optsDiff);
                 }
@@ -533,7 +485,7 @@ angular.module('ui.sortable', [])
             } else {
               $log.info('ui.sortable: ngModel not provided!', element);
             }
-
+            
             // Create sortable
             element.sortable(opts);
           }