Merge pull request #193 from angular-ui/fix-multiple-setviewvalue

fix(multiple): setViewValue compatible with 1.3-rc.1+

Author: dimirc

src/select.js

@@ -579,9 +579,9 @@
               result;
           if ($select.multiple){
             var resultMultiple = [];
-            for (var j = inputValue.length - 1; j >= 0; j--) {
+            for (var j = $select.selected.length - 1; j >= 0; j--) {
               locals = {};
-              locals[$select.parserResult.itemName] = inputValue[j];
+              locals[$select.parserResult.itemName] = $select.selected[j];
               result = $select.parserResult.modelMapper(scope, locals);
               resultMultiple.unshift(result);
             }
@@ -730,10 +730,8 @@
         });
 
         if ($select.multiple){
-          scope.$watchCollection('$select.selected', function(newValue) {
-            //On v1.2.19 the 2nd and 3rd parameteres are ignored
-            //On v1.3.0-beta+ 3rd parameter (revalidate) is true, to force $parsers to recreate model
-            ngModel.$setViewValue(newValue, null, true);
+          scope.$watchCollection('$select.selected', function() {
+            ngModel.$setViewValue(Date.now()); //Set timestamp as a unique string to force changes
           });
           focusser.prop('disabled', true); //Focusser isn't needed if multiple
         }else{

test/select.spec.js

@@ -1337,6 +1337,32 @@ describe('ui-select tests', function() {
 
     });
 
+    it('should change viewvalue only once when updating modelvalue', function () {
+      
+      scope.selection.selectedMultiple = ['wladimir@email.com', 'samantha@email.com'];
+
+      var el = compileTemplate(
+          '<ui-select ng-change="onlyOnce()" multiple ng-model="selection.selectedMultiple" theme="bootstrap" style="width: 800px;"> \
+              <ui-select-match placeholder="Pick one...">{{$item.name}} &lt;{{$item.email}}&gt;</ui-select-match> \
+              <ui-select-choices repeat="person.email as person in people | filter: $select.search"> \
+                <div ng-bind-html="person.name | highlight: $select.search"></div> \
+                <div ng-bind-html="person.email | highlight: $select.search"></div> \
+              </ui-select-choices> \
+          </ui-select> \
+          '
+      );
+
+      scope.counter = 0;
+      scope.onlyOnce = function(){
+        scope.counter++;
+      }
+
+      clickItem(el, 'Nicole');
+
+      expect(scope.counter).toBe(1);
+
+    });
+
   });