Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit cf65a63

Browse files
wesleychowesleycho
committed
chore(docs): fix bootlint warnings
- Fix bootlint warnings Closes #3597 Closes #4075
1 parent a8a22cf commit cf65a63

File tree

12 files changed

+72
-73
lines changed

12 files changed

+72
-73
lines changed

‎misc/demo/index.html

Lines changed: 33 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -24,41 +24,39 @@
2424
<link rel="author" href="https://github.com/angular-ui/bootstrap/graphs/contributors">
2525
</head>
2626
<body class="ng-cloak" ng-controller="MainCtrl">
27-
<header class="navbar navbar-default navbar-fixed-top">
28-
<div class="navbar-inner">
29-
<div class="container">
30-
<div class="navbar-header">
31-
<button type="button" class="navbar-toggle" data-toggle="collapse" data-target="#bs-example-navbar-collapse-3" ng-click="isCollapsed = !isCollapsed">
32-
<span class="sr-only">Toggle navigation</span>
33-
<span class="icon-bar"></span>
34-
<span class="icon-bar"></span>
35-
<span class="icon-bar"></span>
36-
</button>
37-
<a class="navbar-brand visible-xs" href="#">UI Bootstrap</a>
38-
</div>
39-
<nav class="hidden-xs">
40-
<ul class="nav navbar-nav">
41-
<a href="#top" role="button" class="navbar-brand">
42-
UI Bootstrap
43-
</a>
44-
<li class="dropdown" dropdown>
45-
<a role="button" class="dropdown-toggle" dropdown-toggle>
46-
Directives <b class="caret"></b>
47-
</a>
48-
<ul class="dropdown-menu">
49-
<% demoModules.forEach(function(module) { %><li><a href="#<%= module.name %>"><%= module.displayName %></a></li><% }); %>
50-
</ul>
51-
</li>
52-
<li><a href="#getting_started">Getting started</a></li>
53-
</ul>
54-
</nav>
55-
<nav class="visible-xs" collapse="!isCollapsed">
56-
<ul class="nav navbar-nav">
57-
<li><a href="#getting_started" ng-click="isCollapsed = !isCollapsed">Getting started</a></li>
58-
<li><a href="#directives_small" ng-click="isCollapsed = !isCollapsed">Directives</a></li>
59-
</ul>
60-
</nav>
27+
<header class="navbar navbar-default navbar-fixed-top navbar-inner">
28+
<div class="container">
29+
<div class="navbar-header">
30+
<button type="button" class="navbar-toggle" data-toggle="collapse" data-target="#bs-example-navbar-collapse-3" ng-click="isCollapsed = !isCollapsed">
31+
<span class="sr-only">Toggle navigation</span>
32+
<span class="icon-bar"></span>
33+
<span class="icon-bar"></span>
34+
<span class="icon-bar"></span>
35+
</button>
36+
<a class="navbar-brand visible-xs" href="#">UI Bootstrap</a>
6137
</div>
38+
<nav class="hidden-xs">
39+
<ul class="nav navbar-nav">
40+
<a href="#top" role="button" class="navbar-brand">
41+
UI Bootstrap
42+
</a>
43+
<li class="dropdown" dropdown>
44+
<a role="button" class="dropdown-toggle" dropdown-toggle>
45+
Directives <b class="caret"></b>
46+
</a>
47+
<ul class="dropdown-menu">
48+
<% demoModules.forEach(function(module) { %><li><a href="#<%= module.name %>"><%= module.displayName %></a></li><% }); %>
49+
</ul>
50+
</li>
51+
<li><a href="#getting_started">Getting started</a></li>
52+
</ul>
53+
</nav>
54+
<nav class="visible-xs" collapse="!isCollapsed">
55+
<ul class="nav navbar-nav">
56+
<li><a href="#getting_started" ng-click="isCollapsed = !isCollapsed">Getting started</a></li>
57+
<li><a href="#directives_small" ng-click="isCollapsed = !isCollapsed">Directives</a></li>
58+
</ul>
59+
</nav>
6260
</div>
6361
</header>
6462
<div class="header-placeholder"></div>
@@ -195,7 +193,7 @@ <h1><%= module.displayName %><small>
195193
<div class="row code">
196194
<div class="col-md-12" ng-controller="PlunkerCtrl">
197195
<div class="pull-right">
198-
<button class="btn btn-info" id="plunk-btn" ng-click="edit('<%= ngversion%>', '<%= bsversion %>', '<%= pkg.version%>', '<%= module.name %>')"><i class="glyphicon glyphicon-edit"></i> Edit in plunker</button>
196+
<button type="button" class="btn btn-info plunk-btn" ng-click="edit('<%= ngversion%>', '<%= bsversion %>', '<%= pkg.version%>', '<%= module.name %>')"><i class="glyphicon glyphicon-edit"></i> Edit in plunker</button>
199197
</div>
200198
<tabset>
201199
<tab heading="Markup">

‎src/accordion/docs/demo.html

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
<div ng-controller="AccordionDemoCtrl">
22
<p>
3-
<button class="btn btn-default btn-sm" ng-click="status.open = !status.open">Toggle last panel</button>
4-
<button class="btn btn-default btn-sm" ng-click="status.isFirstDisabled = ! status.isFirstDisabled">Enable / Disable first panel</button>
3+
<button type="button" class="btn btn-default btn-sm" ng-click="status.open = !status.open">Toggle last panel</button>
4+
<button type="button" class="btn btn-default btn-sm" ng-click="status.isFirstDisabled = ! status.isFirstDisabled">Enable / Disable first panel</button>
55
</p>
66

7-
<label class="checkbox">
8-
<input type="checkbox" ng-model="oneAtATime">
9-
Open only one at a time
10-
</label>
7+
<div class="checkbox">
8+
<label>
9+
<input type="checkbox" ng-model="oneAtATime">
10+
Open only one at a time
11+
</label>
12+
</div>
1113
<accordion close-others="oneAtATime">
1214
<accordion-group heading="Static Header, initially expanded" is-open="status.isFirstOpen" is-disabled="status.isFirstDisabled">
1315
This content is straight in the template.
@@ -17,7 +19,7 @@
1719
</accordion-group>
1820
<accordion-group heading="Dynamic Body Content">
1921
<p>The body of the accordion group grows to fit the contents</p>
20-
<button class="btn btn-default btn-sm" ng-click="addItem()">Add Item</button>
22+
<button type="button" class="btn btn-default btn-sm" ng-click="addItem()">Add Item</button>
2123
<div ng-repeat="item in items">{{item}}</div>
2224
</accordion-group>
2325
<accordion-group is-open="status.open">

‎src/alert/docs/demo.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<div ng-controller="AlertDemoCtrl">
22
<alert ng-repeat="alert in alerts" type="{{alert.type}}" close="closeAlert($index)">{{alert.msg}}</alert>
3-
<button class='btn btn-default' ng-click="addAlert()">Add Alert</button>
3+
<button type="button" class='btn btn-default' ng-click="addAlert()">Add Alert</button>
44
</div>

‎src/collapse/docs/demo.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div ng-controller="CollapseDemoCtrl">
2-
<button class="btn btn-default" ng-click="isCollapsed = !isCollapsed">Toggle collapse</button>
2+
<button type="button" class="btn btn-default" ng-click="isCollapsed = !isCollapsed">Toggle collapse</button>
33
<hr>
44
<div collapse="isCollapsed">
55
<div class="well well-lg">Some content</div>

‎src/modal/docs/demo.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ <h3 class="modal-title">I'm a modal!</h3>
1212
Selected: <b>{{ selected.item }}</b>
1313
</div>
1414
<div class="modal-footer">
15-
<button class="btn btn-primary" ng-click="ok()">OK</button>
16-
<button class="btn btn-warning" ng-click="cancel()">Cancel</button>
15+
<button class="btn btn-primary" type="button" ng-click="ok()">OK</button>
16+
<button class="btn btn-warning" type="button" ng-click="cancel()">Cancel</button>
1717
</div>
1818
</script>
1919

20-
<button class="btn btn-default" ng-click="open()">Open me!</button>
21-
<button class="btn btn-default" ng-click="open('lg')">Large modal</button>
22-
<button class="btn btn-default" ng-click="open('sm')">Small modal</button>
23-
<button class="btn btn-default" ng-click="toggleAnimation()">Toggle Animation ({{ animationsEnabled }})</button>
20+
<button type="button" class="btn btn-default" ng-click="open()">Open me!</button>
21+
<button type="button" class="btn btn-default" ng-click="open('lg')">Large modal</button>
22+
<button type="button" class="btn btn-default" ng-click="open('sm')">Small modal</button>
23+
<button type="button" class="btn btn-default" ng-click="toggleAnimation()">Toggle Animation ({{ animationsEnabled }})</button>
2424
<div ng-show="selected">Selection from a modal: {{ selected }}</div>
2525
</div>

‎src/pagination/docs/demo.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ <h4>Default</h4>
55
<pagination direction-links="false" boundary-links="true" total-items="totalItems" ng-model="currentPage"></pagination>
66
<pagination direction-links="false" total-items="totalItems" ng-model="currentPage" num-pages="smallnumPages"></pagination>
77
<pre>The selected page no: {{currentPage}}</pre>
8-
<button class="btn btn-info" ng-click="setPage(3)">Set current page to: 3</button>
8+
<button type="button" class="btn btn-info" ng-click="setPage(3)">Set current page to: 3</button>
99

1010
<hr />
1111
<h4>Pager</h4>

‎src/popover/docs/demo.html

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ <h4>Dynamic</h4>
1212
<label>Popup Template:</label>
1313
<input type="text" ng-model="dynamicPopover.templateUrl" class="form-control">
1414
</div>
15-
<button popover="{{dynamicPopover.content}}" popover-title="{{dynamicPopover.title}}" class="btn btn-default">Dynamic Popover</button>
15+
<button popover="{{dynamicPopover.content}}" popover-title="{{dynamicPopover.title}}" type="button" class="btn btn-default">Dynamic Popover</button>
1616

17-
<button popover-template="dynamicPopover.templateUrl" popover-title="{{dynamicPopover.title}}" class="btn btn-default">Popover With Template</button>
17+
<button popover-template="dynamicPopover.templateUrl" popover-title="{{dynamicPopover.title}}" type="button" class="btn btn-default">Popover With Template</button>
1818

1919
<script type="text/ng-template" id="myPopoverTemplate.html">
2020
<div>{{dynamicPopover.content}}</div>
@@ -25,20 +25,20 @@ <h4>Dynamic</h4>
2525
</script>
2626
<hr />
2727
<h4>Positional</h4>
28-
<button popover-placement="top" popover="On the Top!" class="btn btn-default">Top</button>
29-
<button popover-placement="left" popover="On the Left!" class="btn btn-default">Left</button>
30-
<button popover-placement="right" popover="On the Right!" class="btn btn-default">Right</button>
31-
<button popover-placement="bottom" popover="On the Bottom!" class="btn btn-default">Bottom</button>
28+
<button popover-placement="top" popover="On the Top!" type="button" class="btn btn-default">Top</button>
29+
<button popover-placement="left" popover="On the Left!" type="button" class="btn btn-default">Left</button>
30+
<button popover-placement="right" popover="On the Right!" type="button" class="btn btn-default">Right</button>
31+
<button popover-placement="bottom" popover="On the Bottom!" type="button" class="btn btn-default">Bottom</button>
3232

3333
<hr />
3434
<h4>Triggers</h4>
3535
<p>
36-
<button popover="I appeared on mouse enter!" popover-trigger="mouseenter" class="btn btn-default">Mouseenter</button>
36+
<button popover="I appeared on mouse enter!" popover-trigger="mouseenter" type="button" class="btn btn-default">Mouseenter</button>
3737
</p>
3838
<input type="text" value="Click me!" popover="I appeared on focus! Click away and I'll vanish..." popover-trigger="focus" class="form-control">
3939

4040
<hr />
4141
<h4>Other</h4>
42-
<button Popover-animation="true" popover="I fade in and out!" class="btn btn-default">fading</button>
43-
<button popover="I have a title!" popover-title="The title." class="btn btn-default">title</button>
42+
<button Popover-animation="true" popover="I fade in and out!" type="button" class="btn btn-default">fading</button>
43+
<button popover="I have a title!" popover-title="The title." type="button" class="btn btn-default">title</button>
4444
</div>

‎src/progressbar/docs/demo.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ <h3>Static</h3>
88
</div>
99

1010
<hr />
11-
<h3>Dynamic <button class="btn btn-sm btn-primary" type="button" ng-click="random()">Randomize</button></h3>
11+
<h3>Dynamic <button type="button" class="btn btn-sm btn-primary" ng-click="random()">Randomize</button></h3>
1212
<progressbar max="max" value="dynamic"><span style="color:white; white-space:nowrap;">{{dynamic}} / {{max}}</span></progressbar>
1313

1414
<small><em>No animation</em></small>
@@ -18,7 +18,7 @@ <h3>Dynamic <button class="btn btn-sm btn-primary" type="button" ng-click="rando
1818
<progressbar class="progress-striped active" value="dynamic" type="{{type}}">{{type}} <i ng-show="showWarning">!!! Watch out !!!</i></progressbar>
1919

2020
<hr />
21-
<h3>Stacked <button class="btn btn-sm btn-primary" type="button" ng-click="randomStacked()">Randomize</button></h3>
21+
<h3>Stacked <button type="button" class="btn btn-sm btn-primary" ng-click="randomStacked()">Randomize</button></h3>
2222
<progress><bar ng-repeat="bar in stacked track by $index" value="bar.value" type="{{bar.type}}"><span ng-hide="bar.value < 5">{{bar.value}}%</span></bar></progress>
2323

2424
</div>

‎src/rating/docs/demo.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ <h4>Default</h4>
55

66
<pre style="margin:15px 0;">Rate: <b>{{rate}}</b> - Readonly is: <i>{{isReadonly}}</i> - Hovering over: <b>{{overStar || "none"}}</b></pre>
77

8-
<button class="btn btn-sm btn-danger" ng-click="rate = 0" ng-disabled="isReadonly">Clear</button>
9-
<button class="btn btn-sm btn-default" ng-click="isReadonly = ! isReadonly">Toggle Readonly</button>
8+
<button type="button" class="btn btn-sm btn-danger" ng-click="rate = 0" ng-disabled="isReadonly">Clear</button>
9+
<button type="button" class="btn btn-sm btn-default" ng-click="isReadonly = ! isReadonly">Toggle Readonly</button>
1010
<hr />
1111

1212
<h4>Custom icons</h4>

‎src/tabs/docs/demo.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<div ng-controller="TabsDemoCtrl">
22
<p>Select a tab by setting active binding to true:</p>
33
<p>
4-
<button class="btn btn-default btn-sm" ng-click="tabs[0].active = true">Select second tab</button>
5-
<button class="btn btn-default btn-sm" ng-click="tabs[1].active = true">Select third tab</button>
4+
<button type="button" class="btn btn-default btn-sm" ng-click="tabs[0].active = true">Select second tab</button>
5+
<button type="button" class="btn btn-default btn-sm" ng-click="tabs[1].active = true">Select third tab</button>
66
</p>
77
<p>
8-
<button class="btn btn-default btn-sm" ng-click="tabs[1].disabled = ! tabs[1].disabled">Enable / Disable third tab</button>
8+
<button type="button" class="btn btn-default btn-sm" ng-click="tabs[1].disabled = ! tabs[1].disabled">Enable / Disable third tab</button>
99
</p>
1010
<hr />
1111

‎src/timepicker/docs/demo.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717

1818
<hr>
1919

20-
<button class="btn btn-info" ng-click="toggleMode()">12H / 24H</button>
21-
<button class="btn btn-default" ng-click="update()">Set to 14:00</button>
22-
<button class="btn btn-danger" ng-click="clear()">Clear</button>
20+
<button type="button" class="btn btn-info" ng-click="toggleMode()">12H / 24H</button>
21+
<button type="button" class="btn btn-default" ng-click="update()">Set to 14:00</button>
22+
<button type="button" class="btn btn-danger" ng-click="clear()">Clear</button>
2323

2424
</div>

‎template/rating/rating.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
<span ng-mouseleave="reset()" ng-keydown="onKeydown($event)" tabindex="0" role="slider" aria-valuemin="0" aria-valuemax="{{range.length}}" aria-valuenow="{{value}}">
2-
<i ng-repeat="r in range track by $index" ng-mouseenter="enter($index + 1)" ng-click="rate($index + 1)" class="glyphicon" ng-class="$index < value && (r.stateOn || 'glyphicon-star') || (r.stateOff || 'glyphicon-star-empty')" ng-attr-title="{{r.title}}" >
3-
<span class="sr-only">({{ $index < value ? '*' : ' ' }})</span>
4-
</i>
2+
<span ng-repeat-start="r in range track by $index" class="sr-only">({{ $index < value ? '*' : ' ' }})</span>
3+
<i ng-repeat-end ng-mouseenter="enter($index + 1)" ng-click="rate($index + 1)" class="glyphicon" ng-class="$index < value && (r.stateOn || 'glyphicon-star') || (r.stateOff || 'glyphicon-star-empty')" ng-attr-title="{{r.title}}" ></i>
54
</span>

0 commit comments

Comments
 (0)